After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554903 - Add map plugin
Add map plugin
Status: RESOLVED FIXED
Product: eog-plugins
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: EOG Maintainers
EOG Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-03 18:12 UTC by Pierre-Luc Beaudoin
Modified: 2019-02-22 03:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
A map plugin for EOG (14.53 KB, patch)
2008-10-03 18:16 UTC, Pierre-Luc Beaudoin
needs-work Details | Review
Geotagged photo (62.70 KB, image/jpeg)
2008-10-08 19:32 UTC, Pierre-Luc Beaudoin
  Details
Geotagged photo 2 (105.11 KB, image/jpeg)
2008-10-08 19:33 UTC, Pierre-Luc Beaudoin
  Details
A map plugin for EOG (14.79 KB, patch)
2008-10-12 19:53 UTC, Pierre-Luc Beaudoin
none Details | Review
A map plugin for EOG (14.70 KB, patch)
2008-10-12 20:49 UTC, Pierre-Luc Beaudoin
committed Details | Review

Description Pierre-Luc Beaudoin 2008-10-03 18:12:20 UTC
Since EXIF data can contain GPS data, a plugin to display this data on a map should be created.

Such a plugin should display a map on the sidebar. The image's location should clear be identifiable.  

In later versions, the plugin should allow the user to set the image's location on the map.  When that happens, the plugin should write that information into the image's EXIF data.
Comment 1 Pierre-Luc Beaudoin 2008-10-03 18:16:12 UTC
Created attachment 119883 [details] [review]
A map plugin for EOG

This patch uses libchamplain to implement the said plugin.  See http://blog.pierlux.com/projects/libchamplain/ for more information on it.
Comment 2 Pierre-Luc Beaudoin 2008-10-08 19:32:28 UTC
Created attachment 120222 [details]
Geotagged photo
Comment 3 Pierre-Luc Beaudoin 2008-10-08 19:33:57 UTC
Created attachment 120223 [details]
Geotagged photo 2
Comment 4 Claudio Saavedra 2008-10-08 20:32:48 UTC
So, a few nitpicks, nothing important, but please fix, and I'll commit:

- unref thumbnail after setting it in the texture.
- probably need to unref the returned image from eog_thumb_view_get_first_selected_image (view);
- Make reference to champlain-gtk during configuration, if missing.
- There are a few compilation warnings, please fix.
- The indentation of impl_activate() is a bit mix up, same in zoom_in/out. Also, check in general for the indentation.
- Don't use C++ style comments (//)
- Remove spurious spaces

Other than that, the plugin is really funny. I love it. Great work!
Comment 5 Claudio Saavedra 2008-10-08 20:48:09 UTC
There's a warning if there's no images selected (probably happens if you open eog in a directory without images or in a dir with only one image):

** (eog:16367): CRITICAL **: selection_changed_cb: assertion `image != NULL' failed
Comment 6 Pierre-Luc Beaudoin 2008-10-12 19:53:11 UTC
Created attachment 120462 [details] [review]
A map plugin for EOG

Fixed from comments.
Some compile warnings are left (regarding eog_exif_*) until the headers are more widely installed (bug #555942).
Comment 7 Pierre-Luc Beaudoin 2008-10-12 20:49:00 UTC
Created attachment 120473 [details] [review]
A map plugin for EOG

Fix the if { and struct {.
Comment 8 Lucas Rocha 2008-10-12 21:00:27 UTC
Commited in eog-plugins trunk, thanks! Very nice plugin!
Comment 9 Simon Jin 2009-08-07 08:26:33 UTC
It's weird.
why i can't see this plugin in trunk?
Comment 10 jerry tan 2009-08-07 09:06:38 UTC
it seems that the patch is lost during svn to git migration.
Comment 11 Claudio Saavedra 2009-08-07 09:36:53 UTC
Nonono, it is in eog-plugins:

http://git.gnome.org/cgit/eog-plugins
Comment 12 Pierre-Luc Beaudoin 2009-08-07 12:55:43 UTC
It is there: 

http://git.gnome.org/cgit/eog-plugins/tree/plugins/champlain 

It is named champlain...

Note that bug 588397 is affecting this plugin.