GNOME Bugzilla – Bug 554903
Add map plugin
Last modified: 2019-02-22 03:17:14 UTC
Since EXIF data can contain GPS data, a plugin to display this data on a map should be created. Such a plugin should display a map on the sidebar. The image's location should clear be identifiable. In later versions, the plugin should allow the user to set the image's location on the map. When that happens, the plugin should write that information into the image's EXIF data.
Created attachment 119883 [details] [review] A map plugin for EOG This patch uses libchamplain to implement the said plugin. See http://blog.pierlux.com/projects/libchamplain/ for more information on it.
Created attachment 120222 [details] Geotagged photo
Created attachment 120223 [details] Geotagged photo 2
So, a few nitpicks, nothing important, but please fix, and I'll commit: - unref thumbnail after setting it in the texture. - probably need to unref the returned image from eog_thumb_view_get_first_selected_image (view); - Make reference to champlain-gtk during configuration, if missing. - There are a few compilation warnings, please fix. - The indentation of impl_activate() is a bit mix up, same in zoom_in/out. Also, check in general for the indentation. - Don't use C++ style comments (//) - Remove spurious spaces Other than that, the plugin is really funny. I love it. Great work!
There's a warning if there's no images selected (probably happens if you open eog in a directory without images or in a dir with only one image): ** (eog:16367): CRITICAL **: selection_changed_cb: assertion `image != NULL' failed
Created attachment 120462 [details] [review] A map plugin for EOG Fixed from comments. Some compile warnings are left (regarding eog_exif_*) until the headers are more widely installed (bug #555942).
Created attachment 120473 [details] [review] A map plugin for EOG Fix the if { and struct {.
Commited in eog-plugins trunk, thanks! Very nice plugin!
It's weird. why i can't see this plugin in trunk?
it seems that the patch is lost during svn to git migration.
Nonono, it is in eog-plugins: http://git.gnome.org/cgit/eog-plugins
It is there: http://git.gnome.org/cgit/eog-plugins/tree/plugins/champlain It is named champlain... Note that bug 588397 is affecting this plugin.