After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554833 - Be more careful with "struct _<struct_name>"
Be more careful with "struct _<struct_name>"
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
1.10
Other Linux
: Normal normal
: 1.11
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2008-10-03 11:04 UTC by Matthew Barnes
Modified: 2008-10-03 13:38 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (496 bytes, patch)
2008-10-03 11:06 UTC, Matthew Barnes
committed Details | Review

Description Matthew Barnes 2008-10-03 11:04:27 UTC
I had the following declaration in some Evolution code, which was confusing Gtk-Doc and causing it to skip not only that declaration but all subsequent declarations in the file:


struct _EShellView;

...

struct _EShellView *
                e_shell_window_get_shell_view   (EShellWindow *shell_window);


The forward declaration of "struct _EShellView" was to avoid an #include loop.

Gtk-Doc saw the second "struct _EShellView" and assumed it was an "EShellView" declaration.  I patched gtkdoc-scan.in to have it make sure it's not a pointer before making that assumption.
Comment 1 Matthew Barnes 2008-10-03 11:06:58 UTC
Created attachment 119855 [details] [review]
Proposed patch
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2008-10-03 13:38:30 UTC
Thanks for patch!

2008-10-03  Stefan Kost  <ensonic@users.sf.net>

	patch by: Matthew Barnes <mbarnes@redhat.com>

	* gtkdoc-scan.in:
	* tests/bugs/docs/tester-sections.txt:
	* tests/bugs/src/tester.h:
	  Be more careful with "struct _<struct_name>". Fixes #554833.