After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554785 - Compile failure on uri-backend-libcurl
Compile failure on uri-backend-libcurl
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
2.6.0
Other All
: Normal blocker
: 2.6
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2008-10-03 00:29 UTC by Robby Workman
Modified: 2008-10-03 18:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add errno.h to includes and s/filename/tmpname/ (792 bytes, patch)
2008-10-03 00:30 UTC, Robby Workman
committed Details | Review

Description Robby Workman 2008-10-03 00:29:06 UTC
Please describe the problem:
On Slackware -current (development version), I've installed both babl and gegl, as they're not part of Slackware yet and attempted to build gimp-2.6.0.
GTK version is 2.12.x, so gvfs is not available, and we don't ship gnome either, so nor is gnome-vfs; therefore, libcurl it is.

Configure flags:
  --prefix=/usr \
  --sysconfdir=/etc \
  --localstatedir=/var/lib \
  --disable-static \
  --without-gvfs

curl-7.19.0 (full, including headers)

make[3]: Entering directory `/tmp/gimp-2.6.0/plug-ins/file-uri'
gcc -DHAVE_CONFIG_H -I. -I../.. -I../..  -pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/pixman-1   -I/usr/include  -DGIMP_DISABLE_DEPRECATED -DG_DISABLE_DEPRECATED -DGDK_PIXBUF_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DPANGO_DISABLE_DEPRECATED -DGDK_MULTIHEAD_SAFE -DGTK_MULTIHEAD_SAFE  -O2 -march=i486 -mtune=i686 -Wall -Wdeclaration-after-statement -Wmissing-prototypes -Wmissing-declarations -Winit-self -Wpointer-arith -Wold-style-definition -MT uri-backend-libcurl.o -MD -MP -MF .deps/uri-backend-libcurl.Tpo -c -o uri-backend-libcurl.o uri-backend-libcurl.c
uri-backend-libcurl.c: In function 'uri_backend_load_image':
uri-backend-libcurl.c:160: error: 'errno' undeclared (first use in this function)
uri-backend-libcurl.c:160: error: (Each undeclared identifier is reported only once
uri-backend-libcurl.c:160: error: for each function it appears in.)
uri-backend-libcurl.c:162: error: 'filename' undeclared (first use in this function)
make[3]: *** [uri-backend-libcurl.o] Error 1
make[3]: Leaving directory `/tmp/gimp-2.6.0/plug-ins/file-uri'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/tmp/gimp-2.6.0/plug-ins'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/gimp-2.6.0'
make: *** [all] Error 2


Steps to reproduce:
See description.


Actual results:
See description.

Expected results:


Does this happen every time?


Other information:
I'm guessing that this codepath hasn't been run across very often yet, as most people trying out the latest new and shiny gimp have new and shiny gtk-2.14.x as well.  Looking at the code, it seems that errno.h isn't included, and line 160 should have "tmpname" instead of "filename" - a patch is arriving shortly :-)
Comment 1 Robby Workman 2008-10-03 00:30:15 UTC
Created attachment 119835 [details] [review]
Add errno.h to includes and s/filename/tmpname/
Comment 2 Michael Natterer 2008-10-03 12:59:17 UTC
Thanks for the patch! Fixed in SVN:

2008-10-03  Michael Natterer  <mitch@gimp.org>

	Bug 554785 – Compile failure on uri-backend-libcurl

	* plug-ins/file-uri/uri-backend-libcurl.c: apply patch from Robby
	Workman which fixes the build for this file.
Comment 3 Sven Neumann 2008-10-03 13:02:44 UTC
gtk-2.14.x has nothing to do with gvfs being available or not. And I strongly
suggest that you install gvfs-backends as otherwise the online help
functionality is not going to work either.
Comment 4 Robby Workman 2008-10-03 16:35:06 UTC
@ Sven

Er, yeah. My bad on that - if nothing else, I guess that's proof we don't ship gvfs, as I don't know much about it :-)

What's the worst-case scenario with the help browswer?  Best I can tell here, it offers to use the browser instead, and that seems to work fine.  Are you talking about something else?
Comment 5 Sven Neumann 2008-10-03 18:29:09 UTC
Probably best described in http://svenfoo.geekheim.de/2008/07/07/online-help-for-gimp-26/