After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554633 - iPod cover/album art appears on a slant
iPod cover/album art appears on a slant
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Device - iPod
git master
Other All
: Normal minor
: 1.6
Assigned To: Banshee Maintainers
Banshee Maintainers
: 560614 563268 579514 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-10-01 23:13 UTC by Chris Jones
Modified: 2009-08-24 05:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
podsleuth-imageformatquirk.patch (743 bytes, patch)
2008-12-17 00:59 UTC, Nicholas Doyle
none Details | Review

Description Chris Jones 2008-10-01 23:13:09 UTC
Please describe the problem:
Most of the album art which is copied to my iPod Classic 80GB is displayed correctly when I am playing an album and the art is shown in a larger box (similarly in Coverflow mode it works), however, when the art is being displayed in a smaller size as part of a list, the image is distorted, as if each row of pixels is shifted one pixel to the right, wrt the row above, and wraps around.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Bertrand Lorentz 2008-12-05 16:28:44 UTC
*** Bug 563268 has been marked as a duplicate of this bug. ***
Comment 2 Bertrand Lorentz 2008-12-05 16:29:28 UTC
Link to a picture showing the problem, from the duplicate :
http://www.nabble.com/file/p20735796/slanted.JPG
Comment 3 Bertrand Lorentz 2008-12-05 16:30:08 UTC
*** Bug 560614 has been marked as a duplicate of this bug. ***
Comment 4 Nicholas Doyle 2008-12-14 22:37:01 UTC
I am experiencing the same problem on my iPod Classic 120GB (Black).
Comment 5 Nicholas Doyle 2008-12-17 00:59:08 UTC
Created attachment 124837 [details] [review]
podsleuth-imageformatquirk.patch

It turns out some iPods missreport the formats they want for album art sizes. The iPod says it wants images of size 55x55 when it /actually/ wants images of size 56x56. Maybe they assume image dimensions should be multiples of 8 and that data should be padded appropriately (just a random baseless guess)? Anyways, here is a patch to address the quirk. It 'works for me'.
Comment 6 Gabriel Burt 2009-01-13 19:29:21 UTC
Nicholas, I think you've got it!  Here's some addition info from Christophe Fergeau:

"there's a field in SysInfoExtended saying if rows are to be aligned
I don't remember the field name nor if the alignemnt is 16 or 32 bits"

Could you either scan the SysInfoExtended info for that, and/or look in libgpod to see how they ID/handle it?  A more generic fix that uses that flag/info would be great.
Comment 7 Gabriel Burt 2009-01-13 19:52:26 UTC
More info below.

<key>AlignRowBytes</key>
teuf: <true/>
Comment 8 Bertrand Lorentz 2009-04-19 19:08:01 UTC
*** Bug 579514 has been marked as a duplicate of this bug. ***
Comment 9 Gabriel Burt 2009-07-01 02:34:45 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 10 Mark 2009-08-24 04:54:47 UTC
Hi Gabriel,

I have an 80Gb Ipod Classic which reproduces this bug.  I downloaded the latest code from git about an hour ago.  I built the source, then started up Banshee and transferred a bunch of albums to my ipod and the artwork is still messed up.  Has this been added to the source?  

I didn't check out the newest versions of Podsleuth, or ipod-sharp, or TagLib#, would I need the latest versions of these programs to prevent the artwork distortion?

Thanks,
Mark
Comment 11 Bertrand Lorentz 2009-08-24 05:41:10 UTC
Mark,

The fix was in podsleuth, so you need to get it from git master on git.gnome.org.
http://git.gnome.org/cgit/podsleuth