After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554585 - History button uses GTK_STOCK_GO_DOWN
History button uses GTK_STOCK_GO_DOWN
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal minor
: ---
Assigned To: Evince Maintainers
Evince Maintainers
: 572390 621935 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-10-01 16:24 UTC by Josselin Mouette
Modified: 2011-06-19 21:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use GTK_STOCK_GO_BACK instead (461 bytes, patch)
2008-10-01 16:26 UTC, Josselin Mouette 		committed Details | Review

Description Josselin Mouette 2008-10-01 16:24:57 UTC 
Currently, the history button uses the GTK_STOCK_GO_DOWN icon, which is the same as the one used for the "next page" button.
Comment 1 Josselin Mouette 2008-10-01 16:26:38 UTC 
Created attachment 119728 [details] [review]
Use GTK_STOCK_GO_BACK instead

This patch uses the GO_BACK icon instead; it is more suited for this button and this way it looks different from the "next page" button.
Comment 2 Nickolay V. Shmyrev 2008-10-01 21:14:30 UTC 
While I agree current situation is bad, go back seems to be a bad choice. We probably need a custom icon for history.
Comment 3 Josselin Mouette 2008-10-02 08:36:28 UTC 
How about stock_left-with-subpoints ?
Comment 4 Nickolay V. Shmyrev 2008-10-03 21:36:44 UTC 
I'm quite opposed to left, sorry. Can we have something that that looks not like an arrow.
Comment 5 Josselin Mouette 2008-10-03 21:46:30 UTC 
How about the history-view icon that is currently shipped in epiphany then? It could be moved to gnome-icon-theme to make it available for all applications.
Comment 6 Nickolay V. Shmyrev 2008-10-03 21:50:17 UTC 
The one with clock? Book on bookmarks is better, isn't it?
Comment 7 Josselin Mouette 2008-10-03 21:54:27 UTC 
The one with clock is the only one that conveys the idea of going back in time, which after all is what history is about. The bookmark icon is, well, about bookmarks (and BTW is different from the one in gnome-icon-theme for no good reason).
Comment 8 Nickolay V. Shmyrev 2008-10-03 22:05:53 UTC 
Ok, clock is suitable. But it must be placed beside arrows, not in the middle by default then.
Comment 9 Carlos Garcia Campos 2008-10-04 14:45:31 UTC 
Some time ago I proposed something like this:

http://carlosgc.linups.org/files/ev-history.png
Comment 10 Nickolay V. Shmyrev 2009-02-19 20:49:04 UTC 
*** Bug 572390 has been marked as a duplicate of this bug. ***
Comment 11 Carlos Garcia Campos 2011-06-19 10:56:40 UTC 
Review of attachment 119728 [details] [review]:

I agree, although I prefer to fix this using a better widget, I've committed this for now, since it's very confusing to use the same icon for history and page navigation. Thanks!
Comment 12 Carlos Garcia Campos 2011-06-19 14:36:57 UTC 
*** Bug 621935 has been marked as a duplicate of this bug. ***