After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554533 - [xvimagesink] allow setting colorkey if possible
[xvimagesink] allow setting colorkey if possible
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal enhancement
: 0.10.22
Assigned To: Stefan Sauer (gstreamer, gtkdoc dev)
GStreamer Maintainers
: 545288 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-10-01 06:47 UTC by Stefan Sauer (gstreamer, gtkdoc dev)
Modified: 2008-10-22 12:25 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
allow setting the color key and use property probe to test if it is available (15.45 KB, patch)
2008-10-01 08:01 UTC, Stefan Sauer (gstreamer, gtkdoc dev)
committed Details | Review

Description Stefan Sauer (gstreamer, gtkdoc dev) 2008-10-01 06:47:22 UTC
it would be nice if the application can choose an own colorkey if the application intends to do own handling of the colorkeying anyway.
Comment 1 Stefan Sauer (gstreamer, gtkdoc dev) 2008-10-01 08:01:58 UTC
Created attachment 119708 [details] [review]
allow setting the color key and use property probe to test if it is available

The patch adds property probe interface for the atom based properties. This way one can query after the element is in READY, wheter setting the property would actually have effect. Not sure how if GstPropertyProbe is the est way to do this though. It returns NULL for the arry if the property is not available. If it is available it returns a list containing TRUE/FALSE for boolean properties and a int-range for the color-key. And comments?

The patch also updates the test application.
Comment 2 Stefan Sauer (gstreamer, gtkdoc dev) 2008-10-22 10:34:59 UTC
*** Bug 545288 has been marked as a duplicate of this bug. ***
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2008-10-22 12:25:42 UTC
2008-10-22  Stefan Kost  <ensonic@users.sf.net>

	* sys/xvimage/xvimagesink.c:
	* sys/xvimage/xvimagesink.h:
	* tests/icles/Makefile.am:
	* tests/icles/test-colorkey.c:
	  Allow setting colorkey if possible. Implement property probe interface
	  for optional X features (autopaint-colorkey, double-buffer and
	  colorkey). Fixes #554533