After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554485 - regression: open new tab using keyboard shortcut does not open new tab with profile of parent window
regression: open new tab using keyboard shortcut does not open new tab with p...
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: Profiles
2.24.x
Other Linux
: Normal normal
: gnome-2-24
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
fixed-2-24
: 554742 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-09-30 18:57 UTC by Alexander Sack
Modified: 2008-10-02 21:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
reuse screen profile for new_tab and new_window (697 bytes, patch)
2008-09-30 19:18 UTC, Alexander Sack
accepted-commit_now Details | Review

Description Alexander Sack 2008-09-30 18:57:12 UTC
This is a regression introduced in 2.24 cycle

Reproduce:
1. setup a profile "testprofile" (e.g. select a background color, font size etc.)
2. start gnome-terminal --window-with-profile=testprofile
3. hit ctrl+shift+T to open a new tab

expected result:
1. in previous gnome-terminal versions the new tab would have the same profile as its parent window

actual result:
1. the new tab will use the "Default" profile
Comment 1 Alexander Sack 2008-09-30 19:18:30 UTC
Created attachment 119676 [details] [review]
reuse screen profile for new_tab and new_window

the same bug manifests itself for new window (e.g. <shift><ctrl>N)

the patch uses the profile from priv->active_screen and only falls back to "default" profile if screen has no profile.

Not really sure if the fallback case is still needed. I kept it to be safe.
Comment 2 Christian Persch 2008-09-30 19:23:59 UTC
Thanks! Please commit to trunk and gnome-2-24.
Comment 3 Alexander Sack 2008-09-30 19:54:06 UTC
Hi,

I don't have svn commit access. Could you please commit for me giving eventual credits to Alexander Sack <asac@canonical.com>

Thanks!
Comment 4 Christian Persch 2008-10-01 16:38:47 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 5 Christian Persch 2008-10-02 21:16:43 UTC
*** Bug 554742 has been marked as a duplicate of this bug. ***