GNOME Bugzilla – Bug 554420
Seal GtkTextTag
Last modified: 2011-02-04 16:12:14 UTC
GtkTextTag still needs to be sealed, see http://live.gnome.org/GTK%2B/3.0/PendingSealings.
No accessors are needed - GtkTextTag is a completely property-based API.
Created attachment 140710 [details] [review] Proposed patch
Created attachment 140711 [details] [review] Updated patch Sorry, I missed one last time.
Also, not really sure if this is in the scope of this bug.. but should we also do #ifndef GSEAL_ENABLE / #endif around the definitions of GtkTextAppearance and GtkTextAttributes, and then move those definitions into the .c #ifdef GSEAL_ENABLE?
(In reply to comment #4) > Also, not really sure if this is in the scope of this bug.. but should we also > do #ifndef GSEAL_ENABLE / #endif around the definitions of GtkTextAppearance > and GtkTextAttributes, and then move those definitions into the .c #ifdef > GSEAL_ENABLE? Anybody who could comment/answer this, please?
Review of attachment 140711 [details] [review]: The patch looks good, waiting for maintainers aproval
Comment on attachment 140711 [details] [review] Updated patch Looks correct to me.