After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554325 - excel_formula_write criticals
excel_formula_write criticals
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: import/export MS Excel (tm)
git master
Other All
: Normal normal
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2008-09-29 16:39 UTC by sum1
Modified: 2008-10-14 15:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Tentative patch (5.41 KB, patch)
2008-10-02 21:08 UTC, Morten Welinder 		accepted-commit_now Details | Review

Description sum1 2008-09-29 16:39:54 UTC 
Version: r16836
OS: Ubuntu Hardy

Steps to reproduce:
- ssconvert gnumeric/samples/excel/functions.xls /tmp/foo.xls


Console output:

CRITICAL **: excel_formula_write_NAME_v7: assertion `tmp != NULL' failed
CRITICAL **: excel_formula_write_NAME_v8: assertion `tmp != NULL' failed


Backtrace (at first critical):

(gdb) bt

+ Trace 207539

  • #0 IA__g_log
    at /build/buildd/glib2.0-2.16.4/glib/gmessages.c line 516
  • #1 IA__g_return_if_fail_warning
    at /build/buildd/glib2.0-2.16.4/glib/gmessages.c line 532
  • #2 excel_formula_write_NAME_v7
    at ms-formula-write.c line 620
  • #3 write_node
    at ms-formula-write.c line 811
  • #4 write_funcall
    at ms-formula-write.c line 544
  • #5 write_node
    at ms-formula-write.c line 704
  • #6 excel_write_formula
    at ms-formula-write.c line 980
  • #7 excel_write_FORMULA
    at ms-excel-write.c line 3254
  • #8 excel_write_cell
    at ms-excel-write.c line 3441
  • #9 excel_sheet_write_block
    at ms-excel-write.c line 4743
  • #10 excel_write_sheet
    at ms-excel-write.c line 4923
  • #11 excel_write_workbook
    at ms-excel-write.c line 5684
  • #12 excel_write_v7
    at ms-excel-write.c line 5714
  • #13 excel_save
    at boot.c line 271
  • #14 excel_dsf_file_save
    at boot.c line 308
  • #15 go_plugin_loader_module_func_file_save
    at go-plugin-loader-module.c line 323
  • #16 go_plugin_file_saver_save
    at go-plugin-service.c line 749
  • #17 go_file_saver_save
    at file.c line 705
  • #18 wbv_save_to_output
    at workbook-view.c line 846
  • #19 wbv_save_to_uri
    at workbook-view.c line 883
  • #20 wb_view_save_as
    at workbook-view.c line 919
  • #21 convert
    at ssconvert.c line 335
  • #22 main
    at ssconvert.c line 396
  • #2 excel_formula_write_NAME_v7
    at ms-formula-write.c line 620 
$1 = (gpointer) 0x0
Comment 1 Morten Welinder 2008-09-30 01:38:31 UTC 
An expression is used the undefined name "fred".

Relatedly, I notice that excel_foreach_name is accessing expr-name
internals.  We ought to fix that too.
Comment 2 Morten Welinder 2008-10-02 21:08:01 UTC 
Created attachment 119826 [details] [review]
Tentative patch

How about this?

(We need to clean up placeholders, btw.  We have ***three*** indicators:
is_placeholder member, #NAME? value, and placement in ->placeholders.)
Comment 3 Jody Goldberg 2008-10-09 03:53:47 UTC 
Seems reasonable.  Although the amount of infrastructure feels bulky.  We'll end up with a vast library of workbook_foreach_foo at this rate.
Comment 4 Morten Welinder 2008-10-14 15:44:50 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.