After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554297 - Translator comment needed for the Proxy term
Translator comment needed for the Proxy term
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Plugins
2.24.x (obsolete)
Other Linux
: Normal critical
: ---
Assigned To: evolution-plugin-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2008-09-29 13:40 UTC by Gabor Kelemen
Modified: 2009-08-05 15:52 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
Add comment to proxy.c (1.81 KB, patch)
2008-09-29 13:41 UTC, Gabor Kelemen 		committed Details | Review
Add comments to org-gnome-proxy-errors.xml (1.57 KB, patch)
2008-09-29 13:42 UTC, Gabor Kelemen 		committed Details | Review
Add comment to proxy-listing.glade (880 bytes, patch)
2008-09-29 13:42 UTC, Gabor Kelemen 		committed Details | Review
Add comment to proxy-login-dialog.glade (926 bytes, patch)
2008-09-29 13:43 UTC, Gabor Kelemen 		committed Details | Review
Add comment to org-gnome-proxy-login-errors.xml (716 bytes, patch)
2008-09-29 13:44 UTC, Gabor Kelemen 		committed Details | Review

Description Gabor Kelemen 2008-09-29 13:40:51 UTC 
The Groupwise plugin uses the Proxy term with a very different meaning, compared to the usual "network proxy". This is mentioned in a translator comment only one place, which itself is good, but not enough. Please add that comment to the other occurrences of the Proxy term when it means GW proxy.
Comment 1 Gabor Kelemen 2008-09-29 13:41:19 UTC 
Created attachment 119580 [details] [review]
Add comment to proxy.c
Comment 2 Gabor Kelemen 2008-09-29 13:42:13 UTC 
Created attachment 119581 [details] [review]
Add comments to org-gnome-proxy-errors.xml
Comment 3 Gabor Kelemen 2008-09-29 13:42:54 UTC 
Created attachment 119582 [details] [review]
Add comment to proxy-listing.glade
Comment 4 Gabor Kelemen 2008-09-29 13:43:35 UTC 
Created attachment 119583 [details] [review]
Add comment to proxy-login-dialog.glade
Comment 5 Gabor Kelemen 2008-09-29 13:44:09 UTC 
Created attachment 119584 [details] [review]
Add comment to org-gnome-proxy-login-errors.xml
Comment 6 Gabor Kelemen 2008-09-29 14:05:41 UTC 
These patches add appropriate comment to the files in plugins/groupwise-features. I'm not sure if there are some other places that need this too. As network proxy support was added in 2.24, I guess all occurrences of Proxy in 2.22 are referring to the GroupWise proxy - but this is only a guess. So could somebody confirm the meaning of Proxy at the following places (line numbers are from 2.22):

#: ../plugins/mail-account-disable/mail-account-disable.c:47
msgid "Proxy _Logout"

#: ../mail/mail.error.xml.h:63
msgid "If you proceed, all proxy accounts will be deleted permanently."

#: ../mail/mail.error.xml.h:64
msgid ""
"If you proceed, the account information and\n"
"all proxy information will be deleted permanently."
Comment 7 Srinivasa Ragavan 2008-09-30 17:18:22 UTC 
Gabor, fine to commit. Just one remark.

Make 'groupwise' as 'GroupWise'. IIRC, I recently approved a patch for such a clean up.

Commit to stable/trunk after that.
Comment 8 André Klapper 2008-09-30 17:47:23 UTC 
Might be worth a message to gnome-i18n@ to ask for double-checking all translations that deal with Proxy.
Comment 9 Gabor Kelemen 2008-10-01 10:00:05 UTC 
Patches committed to trunk and gnome-2-24. 

Any comment on the other occurrences?

Andre: Sure, I wanted to do that anyway :).
Comment 10 Milan Crha 2009-08-05 15:52:42 UTC 
Closing as patches had been committed some time back. From the comments above I understand the bug is fixed.