After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 554150 - mpeg2dec plugin with disable index seeking issue
mpeg2dec plugin with disable index seeking issue
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other All
: Normal normal
: 0.10.10
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-28 09:15 UTC by Sameer Naik
Modified: 2008-09-28 17:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
FIXES 554150 (3.81 KB, patch)
2008-09-28 09:16 UTC, Sameer Naik
committed Details | Review

Description Sameer Naik 2008-09-28 09:15:32 UTC
Please describe the problem:
if gstreamer is compiled with --disable-index option, thereby disabling the
indexed seeking subsystem in gstreamer, and then if the mpeg2dec plugin is compiled from the gstreamer ugly package, undefined gst_index_* symbols are present in the resulting mpeg2dec plugin.


Steps to reproduce:
compiling gstreamer with --disable-index option and the compiling gst-plugins-ugly raises this issue

Actual results:
undefined gst_index_* symbols are present in the resulting mpeg2dec plugin

Expected results:
gst indexing mechanism's should be eliminated from the resulting mpeg2dec plugin

Does this happen every time?
yes

Other information:
Comment 1 Sameer Naik 2008-09-28 09:16:29 UTC
Created attachment 119519 [details] [review]
FIXES 554150

This issue is basically due to the absence of GST_DISABLE_INDEX macro checks
within the mpeg2dec plugin.

attached is the patch that fixes this issue and has been generated against the
HEAD version of gst-plugins-ugly
Comment 2 Sebastian Dröge (slomo) 2008-09-28 17:33:54 UTC
2008-09-28  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Patch by: Sameer Naik <sameer dot subscriptions at damagehead dot com>

        * ext/mpeg2dec/gstmpeg2dec.c: (gst_mpeg2dec_class_init),
        (handle_slice), (gst_mpeg2dec_sink_event),
        (gst_mpeg2dec_src_event):
        * ext/mpeg2dec/gstmpeg2dec.h:
        Fix compilation with --disable-index. Fixes bug #554150.