After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 553939 - Patch: Enable perl module again
Patch: Enable perl module again
Status: RESOLVED FIXED
Product: Gnumeric
Classification: Applications
Component: General
git master
Other All
: Normal enhancement
: ---
Assigned To: Jody Goldberg
Jody Goldberg
Depends on:
Blocks:
 
 
Reported: 2008-09-26 13:15 UTC by gnomify
Modified: 2008-09-28 21:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Enable perl funcs again (deleted) (3.52 KB, patch)
2008-09-26 13:16 UTC, gnomify 		none Details | Review
Enable perl funcs again (updated) (3.48 KB, patch)
2008-09-26 13:22 UTC, gnomify 		none Details | Review
Updated patch (3.08 KB, patch)
2008-09-27 14:01 UTC, gnomify 		none Details | Review
Updated patch -- NEWS (3.44 KB, patch)
2008-09-28 01:33 UTC, gnomify 		none Details | Review
Updated patch -- NEWS (3.44 KB, patch)
2008-09-28 01:34 UTC, gnomify 		none Details | Review

Description gnomify 2008-09-26 13:15:46 UTC 
Hi

I've found perl plugins are broken and perl_add() returns wrong value.
I fixed some FIXME around here and added extra perl funcs for fun.
Comment 1 gnomify 2008-09-26 13:16:44 UTC 
Created attachment 119422 [details] [review]
Enable perl funcs again (deleted)
Comment 2 gnomify 2008-09-26 13:18:53 UTC 
FYI: I cannot access to svn.gnome.org now.
Comment 3 gnomify 2008-09-26 13:22:04 UTC 
Created attachment 119423 [details] [review]
Enable perl funcs again (updated)
Comment 4 gnomify 2008-09-26 13:26:17 UTC 
Comment on attachment 119422 [details] [review]
Enable perl funcs again (deleted)

Don't apply this -- this includes non-English charactors
Comment 5 gnomify 2008-09-26 13:27:01 UTC 
Comment on attachment 119423 [details] [review]
Enable perl funcs again (updated)

Please apply this patch
Comment 6 Andreas J. Guelzow 2008-09-26 14:11:27 UTC 
Change information about plugins/perl-loader/perl-loader.c should be written to  plugins/perl-loader/ChangeLog rather than ChangeLog. Normally there should also be a plugins/perl-func/ChangeLog since every plugin should have its own ChangeLog.
Comment 7 Morten Welinder 2008-09-26 15:30:37 UTC 
Looks generally good.  func_perl_date needs a "my", though.
help_template_text should probably be static.

The top-level ChangeLog should not be changed for this.  the top-level
NEWS file, on the other hand, ought to have an item about this.
Comment 8 gnomify 2008-09-27 14:01:51 UTC 
Created attachment 119475 [details] [review]
Updated patch

Updated
- Move ChangeLog
- Added 'my' in perl script
- Added static
- Indent paranoia
Comment 9 gnomify 2008-09-28 01:33:47 UTC 
Created attachment 119510 [details] [review]
Updated patch -- NEWS

Please apply this
Comment 10 gnomify 2008-09-28 01:34:53 UTC 
Created attachment 119511 [details] [review]
Updated patch -- NEWS

This is the latest one for this issue -- Please apply this
Comment 11 Morten Welinder 2008-09-28 21:45:06 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.