GNOME Bugzilla – Bug 553823
CodeStyle improvements and minor fixes to the DCCP plugin.
Last modified: 2008-11-20 16:04:00 UTC
There are many issues that should be fixed in the DCCP plugin since it is a work in progress. The patch provided by this bug report touch in the following points based on the codestyle gstreamer document: 1. should descend from an applicable base class if possible 2. make use of GST_BOILERPLATE macros 3. conform to the GStreamer coding style 4. use GST_(DEBUG/*)_OBJECT 5. use dashes in object property names to separate words 6. use correct value, name, nick for enums 7. use underscores in macros/function names/structs 8. should be correctly integrated with configure.ac 9. files implementing elements should be named according to their class name, e.g GstBaseSink -> gstbasesink.c 10. should show up correct in gst-inspect output; no warnings, no unknown types, ... 11. The plug-in should be put in the correct location inside the module: sys/: plug-ins that include system headers/link to system libraries; usually platform-dependent as well name after whatever system "thing" they use (oss, v4l, ...) 12. Plugin documentation following all the requirements of the codestyle gstreamer document 13. The elements should not segfault under any circumstance. This includes: wrong pipelines and bad data 14. All error conditions should be correctly handled using GST_ELEMENT_ERROR and following practice outlined in http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/gstreamer-GstGError.html 15. plugin documentation needs to be added: see gstreamer/docs/README; section on adding plugins and elements; "make update" in docs/plugins and commit the new file; edit -docs.sgml and add an include for the file.
In addition, this is a patchset for continue the development of the plugin as discussed with Stefan Kost in Bug #542390. Thank you, Leandro.
Created attachment 119384 [details] [review] Patchset for the fixes explained in the bug description.
sorry for not taking care earluer. Could you please update the patch. It does not apply easily. $ patch --dry-run -F10 -p0 <dccp_patch10sep08.patch patching file gst/dccp/gstdccpclientsink.c Hunk #1 succeeded at 95 with fuzz 2 (offset -1 lines). Hunk #2 succeeded at 176 (offset -1 lines). Hunk #3 succeeded at 260 (offset -2 lines). Hunk #4 succeeded at 284 (offset -2 lines). Hunk #5 succeeded at 310 (offset -2 lines). patching file gst/dccp/gstdccp.h patching file gst/dccp/gstdccpserversrc.c Reversed (or previously applied) patch detected! Assume -R? [n] n Apply anyway? [n] n Skipping patch. 13 out of 13 hunks ignored -- saving rejects to file gst/dccp/gstdccpserversrc.c.rej patching file gst/dccp/gstdccp.c patching file gst/dccp/gstdccpserversink.c patching file gst/dccp/gstdccpclientsink.h patching file gst/dccp/gstdccpclientsrc.c patching file gst/dccp/gstdccpserversrc.h
Hello Stefan, please consider the new clean patch that I've attached. Thank you, Leandro.
Created attachment 122596 [details] [review] [Patch v2] Patchset for the fixes explained in the bug description. Now this one is applying clearly.
Nope, it does not :/ $ patch --dry-run -p0 <gst-dccp-11122008.patch patching file gst/dccp/gstdccpserversrc.h patching file gst/dccp/gstdccpserversrc.c Hunk #1 FAILED at 56. Hunk #7 FAILED at 227. Hunk #8 succeeded at 281 with fuzz 1 (offset -2 lines). Hunk #9 succeeded at 311 (offset -2 lines). Hunk #10 succeeded at 322 (offset -2 lines). Hunk #11 succeeded at 348 (offset -2 lines). Hunk #12 succeeded at 358 (offset -2 lines). Hunk #13 succeeded at 373 (offset -2 lines). 2 out of 13 hunks FAILED -- saving rejects to file gst/dccp/gstdccpserversrc.c.rej patching file gst/dccp/gstdccp.h patching file gst/dccp/gstdccpclientsrc.c patching file gst/dccp/gstdccp.c patching file gst/dccp/gstdccpclientsink.c Hunk #1 succeeded at 95 with fuzz 2 (offset -1 lines). Hunk #2 succeeded at 176 (offset -1 lines). Hunk #3 succeeded at 260 (offset -2 lines). Hunk #4 succeeded at 284 (offset -2 lines). Hunk #5 succeeded at 310 (offset -2 lines). patching file gst/dccp/gstdccpclientsink.h patching file gst/dccp/gstdccpserversink.c
Stefan, this is very strange. I retrieved again the latest version of DCCP plugin in the repository and applied the patch and it worked for me. I then asked to another person to do the same procedure and it worked too. For me it applies cleanly either using "patch -p0" or "patch --dry-run -p0 <gst-dccp-11122008.patch". Do you have any idea what it is happening? Please advise. Thank you, Leandro.
I did a clean checkout and it just applies fine now. I have no explanation for it as cvs diff showed no changed for the old checkout. Sorry for thye troubles. 2008-11-20 Stefan Kost <ensonic@users.sf.net> patch by: Leandro Melo de Sales <leandroal@gmail.com> * gst/dccp/gstdccp.c: * gst/dccp/gstdccp.h: * gst/dccp/gstdccpclientsink.c: * gst/dccp/gstdccpclientsink.h: * gst/dccp/gstdccpclientsrc.c: * gst/dccp/gstdccpserversink.c: * gst/dccp/gstdccpserversrc.c: * gst/dccp/gstdccpserversrc.h: CodeStyle improvements and minor fixes to the DCCP plugin. Fixes #553823.