GNOME Bugzilla – Bug 553518
Flickr export crashes with System.Net.WebException: Error: NameResolutionFailure
Last modified: 2010-06-25 14:17:57 UTC
Steps to reproduce: 1. Shutdown your net connection 2. Select a image 3. Try to export it to Flickr or 23hq 4. Select the button where you can allow the application to upload images 5. F-Spot crashes Stack trace: o Stacktrace with flickr plugin: Exception in Gtk# callback delegate Note: Applications can use GLib.ExceptionManager.UnhandledException to handle the exception. System.Net.WebException: Error: NameResolutionFailure at System.Net.HttpWebRequest.EndGetRequestStream (IAsyncResult asyncResult) [0x00000] at System.Net.HttpWebRequest.GetRequestStream () [0x00000] at FlickrNet.Flickr.DoGetResponse (System.String url, System.String variables) [0x00000] at FlickrNet.Flickr.GetResponse (System.Collections.Hashtable parameters, TimeSpan cacheTimeout) [0x00000] at FlickrNet.Flickr.GetResponseNoCache (System.Collections.Hashtable parameters) [0x00000] at FlickrNet.Flickr.AuthGetFrob () [0x00000] at FlickrRemote.TryWebLogin () [0x00000] at FSpotFlickrExport.FlickrExport.Login () [0x00000] at FSpotFlickrExport.FlickrExport.HandleClicked (System.Object sender, System.EventArgs args) [0x00000] at GLib.Signal.voidObjectCallback (IntPtr handle, IntPtr data) [0x00000] at GLib.ExceptionManager.RaiseUnhandledException(System.Exception e, Boolean is_terminal) at GLib.Signal.voidObjectCallback(IntPtr handle, IntPtr data) at GLib.Signal.voidObjectCallback(IntPtr , IntPtr ) at Gtk.Application.gtk_main() at Gtk.Application.gtk_main() at Gtk.Application.Run() at Gnome.Program.Run() at FSpot.Driver.Main(System.String[] args) o Stacktrace with 23hq plugin: Exception in Gtk# callback delegate Note: Applications can use GLib.ExceptionManager.UnhandledException to handle the exception. System.Net.WebException: Error: NameResolutionFailure at System.Net.HttpWebRequest.EndGetRequestStream (IAsyncResult asyncResult) [0x00000] at System.Net.HttpWebRequest.GetRequestStream () [0x00000] at FlickrNet.Flickr.DoGetResponse (System.String url, System.String variables) [0x00000] at FlickrNet.Flickr.GetResponse (System.Collections.Hashtable parameters, TimeSpan cacheTimeout) [0x00000] at FlickrNet.Flickr.GetResponseNoCache (System.Collections.Hashtable parameters) [0x00000] at FlickrNet.Flickr.AuthGetFrob () [0x00000] at FlickrRemote.TryWebLogin () [0x00000] at FSpotFlickrExport.FlickrExport.Login () [0x00000] at FSpotFlickrExport.FlickrExport.HandleClicked (System.Object sender, System.EventArgs args) [0x00000] at GLib.Signal.voidObjectCallback (IntPtr handle, IntPtr data) [0x00000] at GLib.ExceptionManager.RaiseUnhandledException(System.Exception e, Boolean is_terminal) at GLib.Signal.voidObjectCallback(IntPtr handle, IntPtr data) at GLib.Signal.voidObjectCallback(IntPtr , IntPtr ) at Gtk.Application.gtk_main() at Gtk.Application.gtk_main() at Gtk.Application.Run() at Gnome.Program.Run() at FSpot.Driver.Main(System.String[] args) Other information:
same report here : https://bugs.edge.launchpad.net/ubuntu/+source/f-spot/+bug/320602 "It can be simulated by 1. iptables -A OUTPUT -o eth0 -p tcp -d www.flickr.com -j DROP 2. run f-spot. 3. select any image and export to flickr 4. click authorized button or 1. iptables -D OUTPUT -p udp --dport 53 -j DROP 2. run f-spot. 3. select any image and export to flickr 4. click authorized button" The reported posted a patch as well which is available here: http://launchpadlibrarian.net/21577967/10_fix_export_crash_FlickrRemote.cs.dpatch
could somebody review this change?
I'm not an experienced coder, but the patch looks incomplete. i.e., it doesn't seem to cover the case when the authorization was already done I'm trying to get a better one here: http://gitorious.org/~maxxer/f-spot/maxxer-cone/commits/flickr_check_connectivity feel free to comment/enhance
could somebody review the change? it's being used in Ubuntu for a while
Merged the patch with small changes (removed the debug statements). commit c17f96b689415636d3e51602b169c4c86f313cdd Author: Lorenzo Milesi <maxxer@yetopen.it> Date: Tue Aug 11 23:11:34 2009 +0200 Don't crash in case of WebException https://bugzilla.gnome.org/show_bug.cgi?id=553518