GNOME Bugzilla – Bug 553458
[PATCH] Aisleriot, Freecell svg icons have black box artifact
Last modified: 2012-01-31 23:18:25 UTC
On my system (Ubuntu hardy), the gnome-aisleriot.svg and gnome-freecell.svg icons have odd black box artifacts in the top right of the icon when made into a PNG file. That is, I can open the files in an svg editor like inkscape, and they look fine. But when I look at the scalable folder in nautilus, the thumbnails have this odd black box in the upper right. Seems to be some bug with librsvg? By process of elimination, I found that there is a <flowRoot> element causing the artifact. It doesn't seem to do anything positive -- that is, removing it didn't cause any problems. I've attached a patch that removes them. Were they intentional?
Created attachment 119247 [details] [review] Proposed patch Copyright Canonical, Ltd
Those icons came from http://gnome-look.org/content/show.php/gnome-games+icons?content=52906 via bug 438032. With the patch attached, do the icons render pixel-identical at, say, 48, 64 and 128 px size? Since you think it's an librsvg problem, have you also filed a librsvg bug for this? (In reply to comment #1) > Copyright Canonical, Ltd A bit daring to claim copyright on a trivial patch that only removes lines... :)
> With the patch attached, do the icons render pixel-identical at, say, 48, 64 and 128 px size? Yes, using inkscape. > Since you think it's an librsvg problem, have you also filed a librsvg bug for this? No, I haven't. My claim of a librsvg bug was wild speculation, and I've not traced this issue down. > A bit daring to claim copyright on a trivial patch that only removes lines... :) ::shrug:: A matter of habit. I wouldn't call it daring, just at worst unnecessary. Even if the patch is so trivial as to not be a copyrightable work, it's still appropriate to say that this patch does not come from me the person, but me the employee. It'd be nice if Bugzilla let me put on different 'hats' and submit comments from different email addresses (without splitting my personality into two different accounts).
Please commit to trunk and gnome-2-24.
Committed to both. Thanks!
This bug is being reassigned to the "general" component so we can close the aisleriot bugzilla component. Apologies for the mass email!