GNOME Bugzilla – Bug 553322
Track number column is not right aligned
Last modified: 2009-01-19 08:42:08 UTC
This might be on purpose but table columns containing numbers are usually aligned on the right. The columns for the track number, the CD number, the year and others are aligned on the left though. Especially for the track number it looks a bit odd to me. Centering that might work as well since there's not much of a difference in width usually.
Created attachment 125029 [details] [review] this patche makes the track number will use right alignment Its my first patch ever, hope it will be accepted. I think there is not much I could do wrong on this little task ;-)
Thanks for the patch. Two issues though : - Patches have to be generated from the top directory of the source (the one containing "configure.ac") - Please use spaces for indentation. For future patches (I hope !), please have a look at the HACKING file for code formatting guidelines.
Created attachment 125040 [details] [review] this patche makes the track number will use right alignment Thank you for your guidance. I recreated the patch using 4 spaces as mentioned in the HACKING guide. This time, I ran the diff from the trunk folder which contains the configure.ac file. I hope that was right. As this patch is my first ever, I think there will be many things I'll have to learn. I'm willing to do so and hope I won't produce too much annoyance on my way though.
No problem, nothing's perfect on the first try. ;) The patch works for me.
will that be commited to trunk?
Thanks for the patch Christoph, I committed it to trunk. I also changes the ColumnCellPositiveInt class so play/skip count, bpm, etc are right aligned now too.
Great, thank you!