After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 553322 - Track number column is not right aligned
Track number column is not right aligned
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
1.2.1
Other Linux
: Normal trivial
: 1.4.2
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-22 22:08 UTC by Shepard
Modified: 2009-01-19 08:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
this patche makes the track number will use right alignment (470 bytes, patch)
2008-12-19 21:15 UTC, christoph.burgdorf
none Details | Review
this patche makes the track number will use right alignment (639 bytes, patch)
2008-12-20 07:58 UTC, christoph.burgdorf
committed Details | Review

Description Shepard 2008-09-22 22:08:54 UTC
This might be on purpose but table columns containing numbers are usually aligned on the right. The columns for the track number, the CD number, the year and others are aligned on the left though. Especially for the track number it looks a bit odd to me. Centering that might work as well since there's not much of a difference in width usually.
Comment 1 christoph.burgdorf 2008-12-19 21:15:23 UTC
Created attachment 125029 [details] [review]
this patche makes the track number will use right alignment

Its my first patch ever, hope it will be accepted. I think there is not much I could do wrong on this little task ;-)
Comment 2 Bertrand Lorentz 2008-12-19 21:31:42 UTC
Thanks for the patch. Two issues though :
- Patches have to be generated from the top directory of the source (the one containing "configure.ac")
- Please use spaces for indentation.

For future patches (I hope !), please have a look at the HACKING file for code formatting guidelines.
Comment 3 christoph.burgdorf 2008-12-20 07:58:13 UTC
Created attachment 125040 [details] [review]
this patche makes the track number will use right alignment

Thank you for your guidance. I recreated the patch using 4 spaces as mentioned in the HACKING guide. This time, I ran the diff from the trunk folder which contains the configure.ac file. I hope that was right.

As this patch is my first ever, I think there will be many things I'll have to learn. I'm willing to do so and hope I won't produce too much annoyance on my way though.
Comment 4 Bertrand Lorentz 2008-12-20 09:44:41 UTC
No problem, nothing's perfect on the first try. ;)

The patch works for me.
Comment 5 christoph.burgdorf 2009-01-15 08:18:37 UTC
will that be commited to trunk?
Comment 6 Gabriel Burt 2009-01-17 20:13:57 UTC
Thanks for the patch Christoph, I committed it to trunk.  I also changes the ColumnCellPositiveInt class so play/skip count, bpm, etc are right aligned now too.
Comment 7 christoph.burgdorf 2009-01-19 08:42:08 UTC
Great, thank you!