After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552869 - "_Skip to" string not appears translated
"_Skip to" string not appears translated
Status: RESOLVED INVALID
Product: totem
Classification: Core
Component: Plugins
unspecified
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-09-19 07:47 UTC by Victor
Modified: 2008-09-22 08:23 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Victor 2008-09-19 07:47:26 UTC
Incorrect translation
Application: totem

Incorrect text:
In all languages except English, does not appears translated the "Go -> Skip to.." option.

Should be:
In the source file "src/plugins/skipto/totem-skipto-plugin.c", if we change the line:
"{ "skip-to", GTK_STOCK_JUMP_TO, N_("_Skip to..."), "<Control>K", N_("Skip to a specific time"), G_CALLBACK (skip_to_action_callback) }"
by this:
"{ "skip-to", GTK_STOCK_JUMP_TO, _("_Skip to..."), "<Control>K", _("Skip to a specific time"), G_CALLBACK (skip_to_action_callback) }"
and compile it again, appears translated those strings. That is, we must remove the "N" for leaving translated these two strings.

Thanks and excuse me for my english, but I'm spanish :P
Comment 1 Sven Neumann 2008-09-19 07:56:44 UTC
The use of N_() is correct here. The proper fix is to add the missing call to gettext() in the place where the string is used. Reassigning to totem.
Comment 2 Bastien Nocera 2008-09-21 18:29:11 UTC
We already use gtk_action_group_set_translation_domain() to get the label translated. So unless that's not working, the entry should be translated.

And it works correctly on my system, translating the entry to French with fr_FR. Which locale and version of Totem were you using?
Comment 3 Victor 2008-09-22 06:56:07 UTC
(In reply to comment #2)
> We already use gtk_action_group_set_translation_domain() to get the label
> translated. So unless that's not working, the entry should be translated.
> 
> And it works correctly on my system, translating the entry to French with
> fr_FR. Which locale and version of Totem were you using?
> 


The totem version is 2.20.0-0ubuntu3 in a Ubuntu 7.10 Gutsy.
I have tried all locale and does not appears translated none.

I would like to have sent a screenshot with fr_FR locale, but "Bugzilla has suffered an internal error".
Comment 4 Bastien Nocera 2008-09-22 07:41:26 UTC
Tell Ubuntu to start updating versions. There were _4_ bug fix releases after 2.20.0: http://ftp.gnome.org/pub/gnome/sources/totem/2.20/

I'm not even checking whether 2.20.4 still has the problem, it's a year and a half old, and wasn't verified with the latest stable from that branch.

Let me know if it's still a problem with 2.20.4.
Comment 5 Victor 2008-09-22 08:23:08 UTC
(In reply to comment #4)
> Tell Ubuntu to start updating versions. There were _4_ bug fix releases after
> 2.20.0: http://ftp.gnome.org/pub/gnome/sources/totem/2.20/
> 
> I'm not even checking whether 2.20.4 still has the problem, it's a year and a
> half old, and wasn't verified with the latest stable from that branch.
> 
> Let me know if it's still a problem with 2.20.4.
> 

Ok, in Ubuntu 8.04 Hardy (totem version is 2.22.1-xxx), the string appears translated.

Excuse me.