After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552559 - Implementation of SLAVE_SKEW in baseaudiosrc
Implementation of SLAVE_SKEW in baseaudiosrc
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 0.10.22
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-16 21:49 UTC by Håvard Graff (hgr)
Modified: 2008-10-08 09:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
the proposed patch (6.28 KB, patch)
2008-09-16 21:50 UTC, Håvard Graff (hgr)
none Details | Review
slightly improved. keeps the code inside SLAVE_SKEW (5.47 KB, patch)
2008-10-07 11:23 UTC, Håvard Graff (hgr)
committed Details | Review

Description Håvard Graff (hgr) 2008-09-16 21:49:50 UTC
This implementation makes sure that the ringbuffers time stays aligned with running_time of the pipeline. In cases of skews, it will realign the ringbuffer_time to the running_time, without doing any dropping of buffers, only retimestamping. It will always align the last buffer written into the ringbuffer (from the device) to running_time, so any buffers already in the ringbuffer will then be "late", but I think this is correct behavior, since elements downstream might choose to drop these buffers, but it is not the job of the ringbuffer to do so.
Comment 1 Håvard Graff (hgr) 2008-09-16 21:50:50 UTC
Created attachment 118846 [details] [review]
the proposed patch
Comment 2 Håvard Graff (hgr) 2008-10-07 11:23:43 UTC
Created attachment 120105 [details] [review]
slightly improved. keeps the code inside SLAVE_SKEW
Comment 3 Wim Taymans 2008-10-08 09:12:38 UTC
        Patch by: Håvard Graff <havard dot graff at tandberg dot com>

        * gst-libs/gst/audio/gstbaseaudiosrc.c:
        (gst_base_audio_src_create):
        Implement skew clock slaving. Fixes #552559.