After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552536 - fix incomplete change to gstdvbsrc.c
fix incomplete change to gstdvbsrc.c
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-16 19:14 UTC by Michael Krufky
Modified: 2008-10-04 21:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gstdvbsrc: fix incomplete change, dont neglect FE_ATSC case (1.10 KB, patch)
2008-09-16 19:15 UTC, Michael Krufky 		committed Details | Review

Description Michael Krufky 2008-09-16 19:14:00 UTC 
The following changeset, "sys/dvb/gstdvbsrc.c: Add DVB Adapter name to structure sent over bus", looks like it was created on an older version of gst-plugins-bad, and the author neglected to rev the ATSC section of the code:

http://cgit.freedesktop.org/~bilboed/gst-plugins-bad/diff/sys/dvb/gstdvbsrc.c?id=d6d546fc5218e4062f4b4ed838354d4613d86930

The attached patch adds the missing line of code to the FE_ATSC case of the switch block.
Comment 1 Michael Krufky 2008-09-16 19:15:20 UTC 
Created attachment 118841 [details] [review]
gstdvbsrc: fix incomplete change, dont neglect FE_ATSC case

In a previous changeset entitled,
"sys/dvb/gstdvbsrc.c: Add DVB Adapter name to structure sent over bus",
The FE_ATSC case was neglected.  This patch adds the missing line of code.

Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Comment 2 Edward Hervey 2008-09-17 06:26:20 UTC 
The patch seems trivial enough to be committed. Zaheer, any comments ?
Comment 3 Zaheer Abbas Merali 2008-09-17 08:40:07 UTC 
My bad, I forgot to add the ATSC case for this patch that was submitted before ATSC support was added to dvbsrc.