After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552356 - Update for new D-Bus APIs
Update for new D-Bus APIs
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: [obsolete] obexftp backend
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
: 522407 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-09-15 14:29 UTC by Bastien Nocera
Modified: 2008-09-29 09:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch! (9.95 KB, patch)
2008-09-15 14:30 UTC, Bastien Nocera 		none Details | Review
Fix deadlock on mounting (10.53 KB, patch)
2008-09-21 07:59 UTC, Bastien Nocera 		none Details | Review
Use new "Icon" property from devices (15.40 KB, patch)
2008-09-23 22:17 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2008-09-15 14:29:40 UTC 
This updates the obexftp backend for the BlueZ 4.x API, as well as the current obex-data-server SVN trunk API.

Don't commit until the changes for obex-data-server have been pushed.
Comment 1 Bastien Nocera 2008-09-15 14:30:36 UTC 
Created attachment 118757 [details] [review]
Patch!
Comment 2 Bastien Nocera 2008-09-21 07:59:08 UTC 
Created attachment 119073 [details] [review]
Fix deadlock on mounting

There was a deadlock on mounting, as I forgot to lock the mutex before waiting on the GCond.
Comment 3 Bastien Nocera 2008-09-22 17:37:06 UTC 
*** Bug 522407 has been marked as a duplicate of this bug. ***
Comment 4 Bastien Nocera 2008-09-23 22:17:31 UTC 
Created attachment 119262 [details] [review]
Use new "Icon" property from devices

Use the "Icon" property available on Device objects:
http://git.kernel.org/?p=bluetooth/bluez.git;a=commit;h=e1a6c133d7a7fd2acf6d3462d200f47ff6124c1b
Comment 5 Bastien Nocera 2008-09-29 09:29:28 UTC 
2008-09-29  Bastien Nocera  <hadess@hadess.net>

        * daemon/gvfsbackendobexftp.c (_is_nokia_3650),
        (get_name_and_icon), (_get_device_properties),
        (g_vfs_backend_obexftp_finalize), (g_vfs_backend_obexftp_init),
        (_query_file_info_helper), (session_connect_error_cb),
        (session_connected_cb), (do_mount),
        (g_vfs_backend_obexftp_class_init):
        * daemon/obexftp-marshal.list:
        Port to BlueZ 4.x API and obex-data-server SVN API,
        use the "Icon" property to get the icon, instead of parsing the 
        device class ourselves (#552356)