GNOME Bugzilla – Bug 552310
leak of pending_info_providers`
Last modified: 2008-09-17 22:35:56 UTC
I'm seeing a lot of leaks like this in my valgrind logs: ==23398== 12 bytes in 1 blocks are definitely lost in loss record 3,091 of 17,943 ==23398== at 0x4006AEE: malloc (vg_replace_malloc.c:207) ==23398== by 0xA88873: g_malloc (gmem.c:131) ==23398== by 0xA9F3F2: g_slice_alloc (gslice.c:824) ==23398== by 0xA7DF25: g_list_prepend (glist.c:169) ==23398== by 0x8142FDC: nautilus_module_get_extensions_for_type (nautilus-module.c:249) ==23398== by 0x81153A9: nautilus_file_invalidate_extension_info_internal (nautilus-file.c:6641) ==23398== by 0x811FD1D: nautilus_file_instance_init (nautilus-file.c:203) ==23398== by 0xB64551: g_type_create_instance (gtype.c:1666) ==23398== by 0xB48964: g_object_constructor (gobject.c:1334) ==23398== by 0x811FCAF: nautilus_file_constructor (nautilus-file.c:214) ==23398== by 0xB49195: g_object_newv (gobject.c:1211) ==23398== by 0xB49D66: g_object_new_valist (gobject.c:1274) ==23398== by 0xB49EDD: g_object_new (gobject.c:1056) ==23398== by 0x811F974: nautilus_file_get_internal (nautilus-file.c:398) ==23398== by 0x811FA10: nautilus_file_get_by_uri (nautilus-file.c:615) And I cannot find code to free pending_info_providers anywhere..
Created attachment 118753 [details] [review] [PATCH] Don't leak the list and properly unref NautilusModule objects. libnautilus-private/nautilus-file.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
It seems we're leaking one list for each NautilusFile object.
Thanks, good catch - and good work Cosimo! As mentioned on IRC, you have to request approval from the release team: http://live.gnome.org/ReleasePlanning/Freezes#ApprovingFreezeBreaks
Committed after approval from the release-team, closing. 2008-09-18 Cosimo Cecchi <cosimoc@gnome.org> * libnautilus-private/nautilus-file.c: (finalize), (nautilus_file_invalidate_extension_info_internal): Don't leak the list of pending info providers (#552310).