GNOME Bugzilla – Bug 552296
Autocompletion on contact names for "new message" dialog box
Last modified: 2008-12-09 09:39:49 UTC
Currently, when one wants to send a new message using the "new message" dialog, the contactID needs to be entered, which is not the most user friendly. Based on http://git.collabora.co.uk/?p=empathy.git;a=commit;h=1304e07b0f56c86f4c9182a25b5f4d584bb47c13 I have commited a branch to http://github.com/chantra/empathy_new_msg_completion/tree/master which makes new message easier to use by enabling auto completion on the contact name.
Created attachment 118719 [details] [review] enabling autocompletion patch
some codig style changes, branch is now at http://github.com/chantra/empathy/tree/new-msg-completion
Sorry to not reply earlier, I looked quickly at your branch. Could you please fix the coding style? We are using tab indentation: http://developer.imendio.com/codingstyle Thanks :)
I will change my indent tab from 2 to 8 :) and ping you back once done.
Created attachment 123858 [details] [review] new autocompletion patch diff against commit 460e2e92a9b9861ebbc5cc318abc9ad57fa4c801 (Mon Dec 1 12:46:27 2008 +0000)
I cleaned your code and merged. About coding style: I changed indentation from 8 spaces to 1 tab, added one space between function name and bracket and cut lines to fit in 80char. Thanks you for your patch!
Hi Xavier, thanks for that, and sorry I did not make a neater patch.