After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552290 - Wrond marking the message for translation
Wrond marking the message for translation
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other All
: Normal minor
: 2.24
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2008-09-14 23:02 UTC by Yuriy Penkin
Modified: 2008-09-15 18:28 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
using plural form (647 bytes, patch)
2008-09-14 23:21 UTC, Yuriy Penkin 		none Details | Review
using plural form v2 (646 bytes, patch)
2008-09-15 15:51 UTC, Yuriy Penkin 		committed Details | Review

Description Yuriy Penkin 2008-09-14 23:02:02 UTC 
Please describe the problem:
src/cheese-window.c:573

primary = g_strdup_printf (_("Are you sure you want to permanently delete the %'d selected items?"), list_length);

Should use plural form here.



Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Yuriy Penkin 2008-09-14 23:21:39 UTC 
Created attachment 118714 [details] [review]
using plural form
Comment 2 daniel g. siegel 2008-09-15 14:15:00 UTC 
sorry, but your patch features the same sentence twice, did you want that?
Comment 3 Yuriy Penkin 2008-09-15 15:51:32 UTC 
Created attachment 118763 [details] [review]
using plural form v2

The first parameter of ngettext doesn't matter for this case (n>1 always), but will be clearer to change it to single form.
Comment 4 daniel g. siegel 2008-09-15 16:08:45 UTC 
hmm.. dont know about this. have you had a look at the code? we already have a look whether to use single form or not:

src/cheese-window.c:
 571     if (list_length > 1)
 572     {
 573       primary = g_strdup_printf (_("Are you sure you want to permanently delete the %'d selected items?"),
 574                                  list_length);
 575     }
 576     else
 577     {
 578       primary = g_strdup_printf (_("Are you sure you want to permanently delete \"%s\"?"),
 579                                  g_file_get_basename (files->data));
 580     }
Comment 5 Yuriy Penkin 2008-09-15 17:03:36 UTC 
(In reply to comment #4)
> we already have a look whether to use single form or not:

It's not enough for correct translation to some languages. Please, read http://live.gnome.org/TranslationProject/DevGuidelines/Plurals
Comment 6 daniel g. siegel 2008-09-15 18:28:10 UTC 
committed to trunk as confirmed by the i18n team