After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552199 - Parsing SDP file with multicast address fails
Parsing SDP file with multicast address fails
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 0.10.22
Assigned To: Wim Taymans
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-14 08:36 UTC by Tero Saarni
Modified: 2008-10-06 16:36 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
stream-with-multicast-address.sdp (772 bytes, text/plain)
2008-09-14 08:37 UTC, Tero Saarni
  Details
debug log: gst-sdpdemux-before-fix.txt (9.32 KB, text/plain)
2008-09-14 08:38 UTC, Tero Saarni
  Details
debug log: gst-sdpdemux-after-fix.txt (6.69 KB, text/plain)
2008-09-14 08:39 UTC, Tero Saarni
  Details
proposed fix: gst-sdp-multicast-address-fix.patch (738 bytes, patch)
2008-09-14 08:39 UTC, Tero Saarni
committed Details | Review

Description Tero Saarni 2008-09-14 08:36:44 UTC
Please describe the problem:
When SDP file has c= field with multicast address the parser fails to remove TTL part and regards that as part of IP address.  See attached files stream-with-multicast-address.sdp and debug log file gst-sdpdemux-before-fix.txt.

According to RFC2327 the address is separated from TTL by "/" character but the code expects whitespace.

See proposed fix in file gst-sdp-multicast-address-fix.patch and gst-sdpdemux-after-fix.txt for a debug log when the patch is applied.



Steps to reproduce:
gst-launch --gst-debug=sdpdemux:5 filesrc location=stream-with-multicast-address.sdp 


Actual results:


Expected results:


Does this happen every time?
yes

Other information:
Excerpt from RFC2327:

   connection-address =  multicast-address
                         | addr

   multicast-address =   3*(decimal-uchar ".") decimal-uchar "/" ttl
                         [ "/" integer ]
Comment 1 Tero Saarni 2008-09-14 08:37:44 UTC
Created attachment 118685 [details]
stream-with-multicast-address.sdp
Comment 2 Tero Saarni 2008-09-14 08:38:23 UTC
Created attachment 118686 [details]
debug log: gst-sdpdemux-before-fix.txt
Comment 3 Tero Saarni 2008-09-14 08:39:01 UTC
Created attachment 118687 [details]
debug log: gst-sdpdemux-after-fix.txt
Comment 4 Tero Saarni 2008-09-14 08:39:47 UTC
Created attachment 118688 [details] [review]
proposed fix: gst-sdp-multicast-address-fix.patch
Comment 5 Wim Taymans 2008-10-06 16:36:19 UTC
        Based on Patch by: Tero Saarni <tero dot saarni at gmail dot com>

        * gst-libs/gst/sdp/gstsdpmessage.c: (gst_sdp_parse_line),
        (print_media), (gst_sdp_message_dump):
        Fix parsing of the c= field containing multicast addresses.
        Fixes #552199.
        Add the connection info to the session or streams.
        Fix parsing of the bandwidth.
        Add debugging for the connections and bandwidths for a media.
        Add debugging for the bandwidth of the session.