GNOME Bugzilla – Bug 552109
won't set wallpaper
Last modified: 2008-09-21 11:02:17 UTC
the bug has been opened on https://bugs.launchpad.net/ubuntu/+source/eog/+bug/269779 "EOG 2.23.92 Using 'Set As Wallpaper' gives plain background and no picture. Appearance Preferences > Background tab shows the same: Plain colour and no picture."
Yes, this is because we write a real URI to GConf since moving to GIO. Looks like this was not fully sane before with GnomeVFS either, but didn't show on local files. I'll see what I can do without requiring freeze breaks.
How is this affected by string freeze? If it is, I think this is important enough to raise a string freeze break.
The problem is that the whole wallpaper thing works with local files only right now. So, we might have to add an error dialog if file is not local (ie. g_file_get_path fails) which would need a string/UI freeze break. Currently I'm wondering if we might even extend that check with g_file_is_native as I'm not sure how far nautilus can cope with GVFS-FUSE mounts.
Created attachment 118702 [details] [review] Use path instead of URI This patch makes EOG set the files path instead of the URI. It also checks if that file is locally on your computer as it wouldn't make sense to set an image from a GVFS-FUSE-Mount as wallpaper as it won't be there on the next login. I'm not sure if the error dialog text is good. So, any comments? :-)
For the secondary message I rather have something more informative, like telling the user to save a copy of the file locally in order to set it as a background. We should hurry, or this won't go into 2.24.0.
Sorry, I didn't find the time to do it yesterday. :-( Don't know about the text. "Only images saved locally on your computer can be set as wallpaper. Please copy the image to your harddisk first." Feels kinda redundant. Maybe just the second line?
Created attachment 119007 [details] [review] Update strings I changed both strings to - "Only local images can be used as wallpapers" - "To be able to set this image as your wallpaper, please save it locally in your computer" I sent the freeze break request. Hopefully we will get it in.
We got the approvals, so I committed to trunk. Felix, if you have the time, can you upload the german translation? I already did with the spanish translation. Lucas, if you are awake, you could do the same with the pt_BR ;-) Thanks! 2008-09-21 Claudio Saavedra <csaavedra@igalia.com> * src/eog-window.c: (eog_window_cmd_wallpaper): Set correctly the wallpaper, and warn about eog not being able to set remote images as wallpapers. Fixes bug #552109 (Felix Riemann, Claudio Saavedra)