After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 552001 - gtkimcontextsimple.c: variable is declared at middle of block
gtkimcontextsimple.c: variable is declared at middle of block
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Input Methods
2.14.x
Other All
: Normal normal
: ---
Assigned To: Hidetoshi Tajima
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2008-09-12 17:14 UTC by Kazuki Iwamoto
Modified: 2008-09-16 04:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch for gtkimcontextsimple.c (671 bytes, patch)
2008-09-12 17:16 UTC, Kazuki Iwamoto 		committed Details | Review

Description Kazuki Iwamoto 2008-09-12 17:14:49 UTC 
Please describe the problem:
'value' is declared at the middle of the block in 'check_algorithmically'.
Old compiler will occur error, because of C99ism.

Steps to reproduce:
1. compile gtkimcontextsimple.c


Actual results:
Following messages are displayed.(Visual C++)
gtkimcontextsimple.c(491) : error C2275: 'gunichar' : illegal use of this type as an expression
        glib/gunicode.h(34) : see declaration of 'gunichar'
gtkimcontextsimple.c(491) : error C2146: syntax error : missing ';' before identifier 'value'
gtkimcontextsimple.c(491) : error C2065: 'value' : undeclared identifier

Expected results:
The declaration should be moved to the top of the block.

Does this happen every time?
Revision 21339 or later

Other information:
Comment 1 Kazuki Iwamoto 2008-09-12 17:16:46 UTC 
Created attachment 118607 [details] [review]
patch for gtkimcontextsimple.c
Comment 2 Matthias Clasen 2008-09-12 17:24:35 UTC 
thanks, please commit
Comment 3 Matthias Clasen 2008-09-16 04:44:34 UTC 
2008-09-16  Matthias Clasen  <mclasen@redhat.com>

        Bug 552001 – gtkimcontextsimple.c: variable is declared at middle of
        block

        * gtk/gtkimcontextsimple.c: Fix a C99ism, pointed out by Kazuki
        Iwamoto.