GNOME Bugzilla – Bug 551850
Remove some old code and fix some leaks.
Last modified: 2009-08-08 16:56:43 UTC
See attached patches.
Created attachment 118530 [details] [review] [PATCH] Deleted themed-icon.[ch] libslab/themed-icon.c | 165 ------------------------------------------------- libslab/themed-icon.h | 53 ---------------- 2 files changed, 0 insertions(+), 218 deletions(-)
Created attachment 118531 [details] [review] [PATCH] Use single GTK+ includes, fix some leaks. application-browser/src/application-browser.c | 8 --- libslab/Makefile.am | 2 - libslab/app-resizer.c | 7 +-- libslab/app-resizer.h | 4 +- libslab/app-shell.c | 3 +- libslab/app-shell.h | 1 - libslab/application-tile.c | 5 +- libslab/gnome-utils.c | 66 ------------------------- libslab/gnome-utils.h | 2 - libslab/search-bar.h | 3 +- libslab/search-context-picker.c | 8 +--- libslab/search-context-picker.h | 2 +- main-menu/src/eggaccelerators.h | 2 +- main-menu/src/hard-drive-status-tile.c | 5 ++- main-menu/src/tomboykeybinder.c | 1 - nautilus-main-menu/nautilus-main-menu.c | 6 -- 16 files changed, 13 insertions(+), 112 deletions(-)
Created attachment 118532 [details] [review] [PATCH] Compile with G*_DISABLE_DEPRECATED. Port to GtkTooltip. application-browser/src/application-browser.c | 1 + libslab/app-shell.c | 9 ++++-- libslab/application-tile.c | 2 +- libslab/directory-tile.c | 2 +- libslab/document-tile.c | 3 +- libslab/nameplate-tile.c | 34 ------------------------- libslab/tile.c | 2 +- main-menu/src/main-menu-ui.c | 6 ++-- 8 files changed, 15 insertions(+), 44 deletions(-)
Created attachment 118536 [details] [review] [PATCH] Use G_DEFINE_TYPE when possible. libslab/app-resizer.c | 41 ++++++-------------------------------- libslab/double-click-detector.c | 36 +-------------------------------- libslab/shell-window.c | 36 +--------------------------------- 3 files changed, 10 insertions(+), 103 deletions(-)
With regards to the patch in comment#3, why do you remove the tooltip from nameplate?
*** Bug 563960 has been marked as a duplicate of this bug. ***
Patch from comment#2 and comment#3 submitted to svn. Patch from comment#1 will not be accepted as it displays broken icons if Icon= in .desktop file contains a full patch or an extension to the icon name. Patch from comment#4 not yet reviewed
Ok, thanks for the review, setting patch status.
A similar patch has been committed some time ago to gnome-main-menu and libslab.