After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 551850 - Remove some old code and fix some leaks.
Remove some old code and fix some leaks.
Status: RESOLVED FIXED
Product: gnome-main-menu
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME main menu maintainers
GNOME main menu maintainers
: 563960 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-09-11 18:18 UTC by Cosimo Cecchi
Modified: 2009-08-08 16:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
[PATCH] Deleted themed-icon.[ch] (6.60 KB, patch)
2008-09-11 18:18 UTC, Cosimo Cecchi
rejected Details | Review
[PATCH] Use single GTK+ includes, fix some leaks. (9.31 KB, patch)
2008-09-11 18:18 UTC, Cosimo Cecchi
committed Details | Review
[PATCH] Compile with G*_DISABLE_DEPRECATED. Port to GtkTooltip. (7.97 KB, patch)
2008-09-11 18:18 UTC, Cosimo Cecchi
committed Details | Review
[PATCH] Use G_DEFINE_TYPE when possible. (6.19 KB, patch)
2008-09-11 19:26 UTC, Cosimo Cecchi
none Details | Review

Description Cosimo Cecchi 2008-09-11 18:18:03 UTC
See attached patches.
Comment 1 Cosimo Cecchi 2008-09-11 18:18:31 UTC
Created attachment 118530 [details] [review]
[PATCH] Deleted themed-icon.[ch]

 libslab/themed-icon.c |  165 -------------------------------------------------
 libslab/themed-icon.h |   53 ----------------
 2 files changed, 0 insertions(+), 218 deletions(-)
Comment 2 Cosimo Cecchi 2008-09-11 18:18:35 UTC
Created attachment 118531 [details] [review]
[PATCH] Use single GTK+ includes, fix some leaks.

 application-browser/src/application-browser.c |    8 ---
 libslab/Makefile.am                           |    2 -
 libslab/app-resizer.c                         |    7 +--
 libslab/app-resizer.h                         |    4 +-
 libslab/app-shell.c                           |    3 +-
 libslab/app-shell.h                           |    1 -
 libslab/application-tile.c                    |    5 +-
 libslab/gnome-utils.c                         |   66 -------------------------
 libslab/gnome-utils.h                         |    2 -
 libslab/search-bar.h                          |    3 +-
 libslab/search-context-picker.c               |    8 +---
 libslab/search-context-picker.h               |    2 +-
 main-menu/src/eggaccelerators.h               |    2 +-
 main-menu/src/hard-drive-status-tile.c        |    5 ++-
 main-menu/src/tomboykeybinder.c               |    1 -
 nautilus-main-menu/nautilus-main-menu.c       |    6 --
 16 files changed, 13 insertions(+), 112 deletions(-)
Comment 3 Cosimo Cecchi 2008-09-11 18:18:39 UTC
Created attachment 118532 [details] [review]
[PATCH] Compile with G*_DISABLE_DEPRECATED. Port to GtkTooltip.

 application-browser/src/application-browser.c |    1 +
 libslab/app-shell.c                           |    9 ++++--
 libslab/application-tile.c                    |    2 +-
 libslab/directory-tile.c                      |    2 +-
 libslab/document-tile.c                       |    3 +-
 libslab/nameplate-tile.c                      |   34 -------------------------
 libslab/tile.c                                |    2 +-
 main-menu/src/main-menu-ui.c                  |    6 ++--
 8 files changed, 15 insertions(+), 44 deletions(-)
Comment 4 Cosimo Cecchi 2008-09-11 19:26:38 UTC
Created attachment 118536 [details] [review]
[PATCH] Use G_DEFINE_TYPE when possible.

 libslab/app-resizer.c           |   41 ++++++--------------------------------
 libslab/double-click-detector.c |   36 +--------------------------------
 libslab/shell-window.c          |   36 +---------------------------------
 3 files changed, 10 insertions(+), 103 deletions(-)
Comment 5 Magnus Boman 2008-12-29 21:45:49 UTC
With regards to the patch in comment#3, why do you remove the tooltip from nameplate?
Comment 6 Magnus Boman 2008-12-29 21:57:24 UTC
*** Bug 563960 has been marked as a duplicate of this bug. ***
Comment 7 Magnus Boman 2009-01-07 01:39:45 UTC
Patch from comment#2 and comment#3 submitted to svn.

Patch from comment#1 will not be accepted as it displays broken icons if Icon= in .desktop file contains a full patch or an extension to the icon name.

Patch from comment#4 not yet reviewed
Comment 8 Cosimo Cecchi 2009-01-16 10:29:43 UTC
Ok, thanks for the review, setting patch status.
Comment 9 Cosimo Cecchi 2009-08-08 16:56:43 UTC
A similar patch has been committed some time ago to gnome-main-menu and libslab.