After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 551650 - Semicolons (or dash) should be used instead of commas for splitting items, time and size
Semicolons (or dash) should be used instead of commas for splitting items, ti...
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other All
: Normal trivial
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-10 12:56 UTC by Pacho Ramos
Modified: 2009-02-10 23:39 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
banshee-comas.png (88.51 KB, image/png)
2008-09-10 12:57 UTC, Pacho Ramos
  Details
banshee-1.0.0-append.patch (974 bytes, patch)
2008-09-10 12:58 UTC, Pacho Ramos
none Details | Review
Use an em-dash (U+2014) for the separator (1.01 KB, patch)
2009-02-10 20:05 UTC, John Millikin
needs-work Details | Review
Use an en-dash (U+2013) for the separator (1.01 KB, patch)
2009-02-10 20:36 UTC, John Millikin
none Details | Review

Description Pacho Ramos 2008-09-10 12:56:56 UTC
Please describe the problem:
Currently, commas are being used for separating items, time and size, I think that semicolons (;) should be used instead because commas (,) are also being used for decimal numbers in time and size

Steps to reproduce:
1. 
2. 
3. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Pacho Ramos 2008-09-10 12:57:43 UTC
Created attachment 118424 [details]
banshee-comas.png

This shows the current behavior
Comment 2 Pacho Ramos 2008-09-10 12:58:27 UTC
Created attachment 118425 [details] [review]
banshee-1.0.0-append.patch

This patch changes "," with "-", but can be easily modified for using ";"
Comment 3 Andrew Conkling 2008-09-10 13:08:48 UTC
I'm not a developer, but I would think that "; " would make more sense. That may depend on languages and their grammar though, I'm not sure.
Comment 4 Pacho Ramos 2008-09-10 13:36:21 UTC
At least in spanish grammar I think that would be better ";" also :-)
Comment 5 Wouter Bolsterlee (uws) 2008-12-08 10:20:38 UTC
A hyphen (-) is incorrect. An em dash (—) might be better. That said, why not use a bit more space instead of debatable characters? Whitespace separation could work quite well I think.
Comment 6 Pacho Ramos 2008-12-08 13:18:57 UTC
Well, I dubt between bigger spaces or ";", but both look ok to me :-)

At least in spanish, seems that it could be used as said in http://buscon.rae.es/dpdI/SrvltGUIBusDPD?lema=punto%20y%20coma in "a)" (sorry, it is only in spanish :-( )

In french seems that it could be also used for this:
http://fr.wikipedia.org/wiki/Point-virgule#En_fran.C3.A7ais

but I don't speak french too well, maybe translation teams could be added to CC list for considering if ";" usage would be ok
Comment 7 Gabriel Burt 2009-01-14 01:22:45 UTC
Hrm, I do like how it looks w/ the em dash.  Is there any good argument for making the separator a translated string?
Comment 8 Wouter Bolsterlee (uws) 2009-01-14 10:37:03 UTC
(In reply to comment #7)
> Hrm, I do like how it looks w/ the em dash.  Is there any good argument for
> making the separator a translated string?

No. There is no reason. Just make it a fixed string.
Comment 9 John Millikin 2009-02-10 20:05:18 UTC
Created attachment 128407 [details] [review]
Use an em-dash (U+2014) for the separator
Comment 10 Wouter Bolsterlee (uws) 2009-02-10 20:26:02 UTC
(In reply to comment #9)
> Created an attachment (id=128407) [edit]
> Use an em-dash (U+2014) for the separator

<warning> Typographical nitpicking! <warning>

The Elements of Typographic Style recommends the more concise spaced en dash – like so – see http://en.wikipedia.org/wiki/Em_dash#En_dash_versus_em_dash for more information. So... U+2013 should be used instead!
Comment 11 John Millikin 2009-02-10 20:36:40 UTC
Created attachment 128410 [details] [review]
Use an en-dash (U+2013) for the separator
Comment 12 Gabriel Burt 2009-02-10 22:28:40 UTC
I committed a modified version, using the ndash.
Comment 13 Andrew Conkling 2009-02-10 23:39:56 UTC
Looks quite good; thanks for getting this in!