GNOME Bugzilla – Bug 551222
Wrong "%s left" string marked for l10n in the file-transfer progress dialog
Last modified: 2009-01-29 13:57:01 UTC
Please describe the problem: When you transfer files with nautilus, a progress dialog is shown. Under the progress bar, there's an ETA saying, e.g., "15 seconds left", or "1 minute left". While in English you've got just a plural for "second" <-> "seconds", "minute" <-> "minutes", "hour" <-> "hours" and "day" <-> "days", in other languages such in Italian the verb has to express the same multeplicity of the subject. So, for example, you'd have: "1 minute left" <-> "1 minuto rimanente" "5 minutes left" <-> "5 minuti rimanenti" As you can see, you pass from "minuto" to "minuti" with the plural, as you do with the verb too ("rimanent(e|i)" is the translation of "left"). So, instead of what's probably _("%s left") in the source, you should use ("%s", minutes == 1 ? _("minute left") : _("minutes left")). I've not looked at the source, though. The same problem may recurr elsewhere in the source when handling plurals. Steps to reproduce: 1. Start a file transfer with the C locale. Look at the time remaining when it's > 1 minute and exactly one minute, or do the same with seconds. 2. Start it in another language, like Italian. Actual results: You read "5 minuti rimanenti" and "1 minuto rimanenti". Expected results: You should respectively read "5 minuti rimanenti" and "1 minuto rimanente". Does this happen every time? Oh yes. Other information:
Thanks, good catch! Confirming. Unfortunately, we may not change strings at this point of the development cycle (”string freeze”), so you will have to wait for the GNOME 2.26 release.
Created attachment 118307 [details] [review] Patch
Marking patch as obsolete. Matteo: What happens in Italian if a phrase reads “3 hours, 4 minutes left“? In German, we count the minutes when deciding whether to use the singular or plural form of “left”. Assuming you do the same thing in Italian, I'll use that form.
Yep, Italian behaves as German in this regard. It's because you're counting two things: "hours AND minutes". Even if it is "ONE hour AND ONE minute" you're still counting TWO things.
Created attachment 118329 [details] [review] Patch OK, thanks. Then we'll use the attached patch once string freeze is over.
String freeze is over. Please commit soon.
"%T left" is used in several other places too, so this fix seems not complete.
I fixed this in trunk, hopefully taking care of the other cases as well. 2009-01-29 Cosimo Cecchi <cosimoc@gnome.org> * libnautilus-private/nautilus-file-operations.c: (seconds_count_format_time_units), (report_delete_progress), (report_copy_progress): make sure to use the correct singular or plural form for the time format when reporting a file operation progress detail. Thanks to Christian Neumair (#551222).