After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 551146 - [PATCH] cpio: escaped filenames and block devices support
[PATCH] cpio: escaped filenames and block devices support
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
2.23.x
Other All
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2008-09-06 19:20 UTC by Eric Piel
Modified: 2008-09-07 06:51 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
cpio archive from hell (512 bytes, application/octet-stream)
2008-09-06 19:22 UTC, Eric Piel 		  Details
Add support for escaped names and block devices (3.34 KB, patch)
2008-09-06 19:25 UTC, Eric Piel 		none Details | Review

Description Eric Piel 2008-09-06 19:20:01 UTC 
Please describe the problem:
Filenames with spaces or non-ascii characters are not correctly parsed for cpio archives. This was recently fixed for rpm (which uses cpio as a backend). I'll attach a patch that fixes it for cpio. It also fixes the parsing of block devices. 

Steps to reproduce:
I'll attach a small cpio archive containing all sort of difficulties, that gets correctly parsed when the patch is applied. 


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Eric Piel 2008-09-06 19:22:28 UTC 
Created attachment 118174 [details]
cpio archive from hell

To be used as a test-case.
Comment 2 Eric Piel 2008-09-06 19:25:25 UTC 
Created attachment 118175 [details] [review]
Add support for escaped names and block devices

This patch also tries to align as much as possible the functions to the rpm support functions in order to keep the maintenance burden to the minimum.
Comment 3 Paolo Bacchilega 2008-09-07 06:51:42 UTC 
patch applied to trunk, thanks.