Created attachment 118153 [details] [review]
hide the tab close button where there is a single tab

This patch hides the tab close button when there is a single tab.

About the code itself: there was already a bunch of g_object_set_data(), I am adding one but it may be the sign of a needed refactoring.

Thanks, looks good :D

Thanks; commited in r1426.

Now the close button suddenly vanishes when I get to one tab, which means I can't point at the right-most × and repeatedly mash the mouse button to close all the tabs.

(Yes, I could click the other ×.)

Will, there is obviously no solution between your requirements and this bug. In fact I agree with you but I use ctr-W anyway...

I see three options:

 1) Keep the current behaviour (close buttons on tabs when there's more than one tab). This might be less confusing (no redundant close buttons).
 2) Revert to the old behaviour (close button on tabs always). This is arguably more consistent because close buttons don't suddenly disappear.
 3) Don't use tabs when there is only one conversation in the window. This is what Epiphany does, but arguably introduces a different consistency.

Xavier: yes, I know.  I think I am probably doing it wrong, and should click the window's × button, but thought I should register my surprise at the × going away.  :-)

(I would use ^W, but I avoid pressing it because I can never remember whether it deletes the last word or closes the tab…)