After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 550729 - gst-plugins-base won't compile with "-pedantic" option
gst-plugins-base won't compile with "-pedantic" option
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal normal
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-03 19:40 UTC by Tristan Matthews
Modified: 2008-09-13 11:14 UTC
See Also:
GNOME target: ---
GNOME version: 2.21/2.22


Attachments
Removes extra comma in gst/gst-libs/audio/audio.h (1.07 KB, patch)
2008-09-03 19:41 UTC, Tristan Matthews
committed Details | Review

Description Tristan Matthews 2008-09-03 19:40:20 UTC
Please describe the problem:
Due to an unneeded comma in gst-plugins-base/gst-libs/gst/audio/audio.h, one cannot compile programs that include this header (or for example gst/audio/multichannel.h) when using the -pedantic option in gcc. This patch removes the extra comma.

Steps to reproduce:
Compile an application with the -pedantic option that includes <gst/audio/audio.h>

Actual results:
Compilation fails.

Expected results:
It should compile.

Does this happen every time?
Yes.

Other information:
Comment 1 Tristan Matthews 2008-09-03 19:41:11 UTC
Created attachment 117955 [details] [review]
Removes extra comma in gst/gst-libs/audio/audio.h
Comment 2 Tim-Philipp Müller 2008-09-13 11:14:30 UTC
Thanks, committed (somewhat accidentally even though -base is frozen, but it's harmless enough):

 2008-09-13  Tim-Philipp Müller  <tim.muller at collabora co uk>

	* gst-libs/gst/audio/audio.h: (GST_AUDIO_FIELD_SIGNED):
	  Remove trailing comma from enum list, which causes problems
	  with -pendantic (#550729).