After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 550675 - close button in the aboutdialog example does nothing
close button in the aboutdialog example does nothing
Status: RESOLVED FIXED
Product: gtkmm
Classification: Bindings
Component: documentation
2.13.x
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2008-09-03 14:42 UTC by Götz Waschk
Modified: 2008-09-04 13:09 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
fix logic (467 bytes, patch)
2008-09-04 10:40 UTC, Götz Waschk 		none Details | Review

Description Götz Waschk 2008-09-03 14:42:58 UTC 
The example program in examples/book/dialogs/aboutdialog has a bug. The close button has no effect, you have to use the window manager's button to close the dialog. This is with gtkmm 2.19.7, gtkmm-documentation 2.13.2 and gtk 2.13.7.
Comment 1 Murray Cumming 2008-09-03 15:35:48 UTC 
Fixed in svn. Thanks.

2008-09-03  Murray Cumming  <murrayc@murrayc.com>

	* examples/book/dialogs/aboutdialog/examplewindow.cc:
	* examples/book/dialogs/aboutdialog/examplewindow.h: Respond to the Close 
	button. Bug #550675 (Götz Waschk).
Comment 2 Götz Waschk 2008-09-03 16:34:28 UTC 
Your fix will only work in a universe were -6 == -7:
if((response_id == Gtk::RESPONSE_CLOSE) &&
     (response_id == Gtk::RESPONSE_CANCEL) )
  {
    m_Dialog.hide();
  }
Comment 3 Götz Waschk 2008-09-04 10:40:10 UTC 
Created attachment 117993 [details] [review]
fix logic
Comment 4 Jonathon Jongsma 2008-09-04 13:09:47 UTC 
committed, thanks.  In the future, it would be much easier if the patch were made from the root of the repository and the changelog were patched as well.  thanks for the review.