GNOME Bugzilla – Bug 550657
New element jasperdec
Last modified: 2008-09-09 17:56:50 UTC
The Jasper library is the reference implementation for JPEG2000 encoder/decoder. The new plugin in question provides a decoder wrapper for use with e.g. video/mj2 or image/jp2 files.
Created attachment 117928 [details] [review] Jasperdec plugin * Jasper decoder plugin.
This looks great, please commit it. Some minor suggestions: - in _reset(), add a dec->mat=NULL and move the dec->codec_data=NULL up directly behind the unref. - the plugin name needs to be changed so it doesn't conflict with the existing "jasper" plugin from gst-plugins-farsight (maybe jasper-j2k? or jasper-jpeg2000? or just jpeg2000dec? or jjpeg2000dec? or ...?) - the element name also needs to be changed to something != "jasperdec", for the same reason - the element GType (structure name passed as first arg to GST_BOILERPLATE) also needs to be changed to something != "GstJasperDec", sadly
(Err, the plugin name obviously shouldn't have any "dec" in it, only the element name)
Created attachment 118249 [details] [review] jp2kdec plugin Ok, thanks for the comments. Attached patch has all required "higher level" elements renamed to jp2k and alike (plugin, element, libtool library, etc), whereas the lower level internals are kept as they were (jasper etc) for historical reasons :) Unless other remarks, I'll commit that soon.
2008-09-09 Mark Nauwelaerts <mark.nauwelaerts@collabora.co.uk> * configure.ac: * ext/Makefile.am: * ext/jp2k/Makefile.am: * ext/jp2k/gstjasperdec.c: (gst_jasper_dec_base_init), (gst_jasper_dec_class_init), (gst_jasper_dec_init), (gst_jasper_dec_reset), (gst_jasper_dec_sink_setcaps), (gst_jasper_dec_negotiate), (gst_jasper_dec_get_picture), (gst_jasper_dec_chain), (gst_jasper_dec_set_property), (gst_jasper_dec_get_property), (gst_jasper_dec_change_state), (plugin_init): * ext/jp2k/gstjasperdec.h: Add jp2k plugin. Fixes #550657.