After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 550468 - [name conflict] New Fluendo mpeg demuxers
[name conflict] New Fluendo mpeg demuxers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: High major
: 0.10.9
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-02 14:11 UTC by Edward Hervey
Modified: 2008-09-09 11:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed renamings (3.58 KB, patch)
2008-09-09 11:09 UTC, Edward Hervey 		committed Details | Review

Description Edward Hervey 2008-09-02 14:11:10 UTC 
The newly landed mpeg demuxers from Fluendo still have their original names (for plugin and ElementFactory).

bilboed@putamadre ~/work/devel/gst-plugins-bad $ gst-inspect-0.10 | grep flu
flumpegdemux:  flutsdemux: MPEG Transport stream demuxer
flumpegdemux:  flupsdemux: MPEG Program Demuxer
flumpegdemux:  flutsdemux: MPEG Transport stream demuxer
flumpegdemux:  flupsdemux: MPEG Program Demuxer

This creates a conflict for people who (already) have the gst-fluendo-mpegdemuxer package installed.

Those new demuxers should be renamed to names that don't conflict with either:
* gst-fluendo-mpegdemuxer (the historical ones), or
* mpegstream/mpegdemux (from gst-plugins-ugly).

Some proposals:

* plugin name : mpgdemux, mpegdemux2, ...
* element names : mpegtsdemux, mpegpsdemux, ...
Comment 1 Edward Hervey 2008-09-09 11:09:58 UTC 
Created attachment 118351 [details] [review]
Proposed renamings
Comment 2 Tim-Philipp Müller 2008-09-09 11:12:27 UTC 
Looks exactly like what I had in mind.
Comment 3 Jan Schmidt 2008-09-09 11:15:46 UTC 
+1
Comment 4 Edward Hervey 2008-09-09 11:47:59 UTC 
2008-09-09  Edward Hervey  <edward.hervey@collabora.co.uk>

	* gst/mpegdemux/flumpegdemux.c: (plugin_init):
	* gst/mpegdemux/gstmpegdemux.c: (gst_flups_demux_sync_get_type),
	(gst_flups_demux_get_type), (gst_flups_demux_plugin_init):
	* gst/mpegdemux/gstmpegtsdemux.c: (gst_fluts_demux_get_type),
	(gst_fluts_demux_plugin_init):
	Fix conflicting public names in new mpeg demuxers.
	Fixes #550468