After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 550211 - Add --logout-dialog and --shutdown-dialog to gnome-session-save
Add --logout-dialog and --shutdown-dialog to gnome-session-save
Status: RESOLVED FIXED
Product: gnome-session
Classification: Core
Component: gnome-session
2.23.x
Other Linux
: Normal normal
: ---
Assigned To: Session Maintainers
Session Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-09-01 13:27 UTC by Vincent Untz
Modified: 2008-09-01 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Implement the two new options (3.54 KB, patch)
2008-09-01 13:30 UTC, Vincent Untz 		none Details | Review

Description Vincent Untz 2008-09-01 13:27:29 UTC 
We have a --kill option for gnome-session-save, but because of history and because we don't want to break compatibility, it's hard to know exactly how it works with --gui and with --silent? What happens if you just do --kill? Does it show a dialog or not?

I propose to add --logout-dialog and --shutdown-dialog which are pretty clear.
Comment 1 Vincent Untz 2008-09-01 13:30:13 UTC 
Created attachment 117764 [details] [review]
Implement the two new options

We could share more code between logout_session() and do_shutdown_dialog() -- trivial to do so, but I wanted feedback first. (also, I'd rename logout_session() to do_logout())

There are new strings. I'll likely put this in openSUSE. Is this something we can commit in 2.24?
Comment 2 William Jon McCann 2008-09-01 14:46:03 UTC 
Yeah, I've always disliked that ambiguity too.  Maybe we should add a --force-logout option too and completely deprecate --kill?

This looks good to me.
Comment 3 Vincent Untz 2008-09-01 15:01:46 UTC 
Well, would --force-logout just not show the logout dialog? Or would it also ignore the inhibitors? Maybe we should add --logout (does not ignore inhibitors) and --force-logout (ignore inhibitors). Need to think a bit about it.

Just found out that I should update the man page too. It will be a good place to add the deprecation note.
Comment 4 Vincent Untz 2008-09-01 16:49:54 UTC 
I've added --logout and --force-logout, cleaned up the code and updated the man page.