After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 550114 - Task tooltips are off by one
Task tooltips are off by one
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Tasks
2.24.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-calendar-maintainers
Evolution QA team
: 554148 559788 577743 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-08-31 19:50 UTC by Matthew Barnes
Modified: 2009-04-02 19:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot (140.07 KB, image/png)
2008-11-24 14:05 UTC, Matthew Barnes 		  Details
proposed evo patch (13.06 KB, patch)
2008-11-25 15:42 UTC, Milan Crha 		committed Details | Review
Screencast (945.84 KB, video/x-theora+ogg)
2009-02-12 21:06 UTC, Matthew Barnes 		  Details

Description Matthew Barnes 2008-08-31 19:50:04 UTC 
When hovering over a list of tasks, the tooltip that popups up shows information for the task in the row _above_ where the mouse is pointing.

(Also, didn't we ever implement tooltips for memos?)
Comment 1 Matthew Barnes 2008-11-24 14:05:17 UTC 
Created attachment 123322 [details]
Screenshot
Comment 2 Milan Crha 2008-11-25 15:42:09 UTC 
Created attachment 123367 [details] [review]
proposed evo patch

for evolution;

I do not like ETable hacking much, really. Anyway, I found out the computation of mouse over is a bit redundant and thus I changed it. It's not so perfect, but it's same bad as the other parts, so good enough, I believe.

With tooltips over memos, hmm, it's working probably only in the calendar view, if at all. I added to EMemoTable too.
Comment 3 Milan Crha 2008-11-25 15:43:22 UTC 
Oh, I forgot, the problem was with grouping columns. Should be better now.
Comment 4 Srinivasa Ragavan 2008-11-27 09:47:45 UTC 
Matt, this looks fine to me, but haven't tesded it, would you flag this to commit once you test it?
Comment 5 Ruchir Brahmbhatt 2008-12-08 17:28:17 UTC 
*** Bug 554148 has been marked as a duplicate of this bug. ***
Comment 6 Milan Crha 2009-01-23 16:19:48 UTC 
ping Matt.
Comment 7 Matthew Barnes 2009-02-12 21:06:24 UTC 
Created attachment 128587 [details]
Screencast

API is cleaner now but I'm still seeing the off-by-one problem.  But I noticed something new: the bug only happens when using grouping.  Tooltips over a flat list work fine.

Here's a screencast so you can see exactly what I'm seeing.  In the first part I mouse over a flat list, and the tooltip is accurate down to the pixel.  Then I group by "Completed", and you can see the tooltips are off by one save for a few pixel rows at the bottom of the cell.  So it must be the group header height being miscalculated.
Comment 8 Milan Crha 2009-02-13 10:49:11 UTC 
Are you sure you compiled widgets/table part too? Because when I apply patch to trunk of revision 37237, go to widgets/table and do make && make install, and the same in a calendar subdirectory, and doing the same steps as you in your video, it works fine.
Comment 9 Matthew Barnes 2009-02-13 12:27:35 UTC 
Let me try it again.  I've been working on kill-bonobo for so long that I keep forgetting to reset bonobo-activation-server when I build from trunk.
Comment 10 Matthew Barnes 2009-02-14 04:18:06 UTC 
You're right, it's working fine now after I reset b-a-s.  Please commit.
Comment 11 Milan Crha 2009-02-16 11:01:12 UTC 
Committed to trunk. Committed revision 37275.
Comment 12 Ruchir Brahmbhatt 2009-03-13 09:01:16 UTC 
I confirm that it is working in nightly builds.
Comment 13 Matthew Barnes 2009-03-20 12:56:58 UTC 
*** Bug 559788 has been marked as a duplicate of this bug. ***
Comment 14 Matthew Barnes 2009-04-02 19:55:25 UTC 
*** Bug 577743 has been marked as a duplicate of this bug. ***