After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 550015 - build failure: gstcmmlparser.c:115: error: format not a string literal and no format arguments
build failure: gstcmmlparser.c:115: error: format not a string literal and no...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal minor
: 0.10.11
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-08-31 05:51 UTC by Craig Keogh
Modified: 2008-08-31 08:32 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24

Attachments
patch to fix 'format not a string literal and no format arguments' (637 bytes, patch)
2008-08-31 05:52 UTC, Craig Keogh 		committed Details | Review

Description Craig Keogh 2008-08-31 05:51:56 UTC 
Building gst-plugins-good HEAD using jhbuild on Ubuntu intrepid, the following error occurs:

libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -pthread -I/opt/gnome2/include/gstreamer-0.10 -I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib64/glib-2.0/include -I/opt/gnome2/include/libxml2 -pthread -I/opt/gnome2/include/gstreamer-0.10 -I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib64/glib-2.0/include -I/opt/gnome2/include/libxml2 -I../../gst-libs -I../../gst-libs -pthread -I/opt/gnome2/include/gstreamer-0.10 -I/opt/gnome2/include/glib-2.0 -I/opt/gnome2/lib64/glib-2.0/include -I/opt/gnome2/include/libxml2 -Wall -Wdeclaration-after-statement -Wvla -Werror -fno-strict-aliasing -g -DGST_DISABLE_DEPRECATED -I/opt/gnome2/include/libxml2 -g -O0 -MT libgstannodex_la-gstcmmlparser.lo -MD -MP -MF .deps/libgstannodex_la-gstcmmlparser.Tpo -c gstcmmlparser.c  -fPIC -DPIC -o .libs/libgstannodex_la-gstcmmlparser.o
cc1: warnings being treated as errors
gstcmmlparser.c: In function ‘gst_cmml_parser_parse_chunk’:
gstcmmlparser.c:115: error: format not a string literal and no format arguments
make[3]: *** [libgstannodex_la-gstcmmlparser.lo] Error 1
make[3]: Leaving directory `/home/oxyde/cvs/gnome2/gst-plugins-good/ext/annodex'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/oxyde/cvs/gnome2/gst-plugins-good/ext'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/oxyde/cvs/gnome2/gst-plugins-good'
make: *** [all] Error 2
Comment 1 Craig Keogh 2008-08-31 05:52:58 UTC 
Created attachment 117679 [details] [review]
patch to fix 'format not a string literal and no format arguments'
Comment 2 Sebastian Dröge (slomo) 2008-08-31 08:32:44 UTC 
You'll probably have some more fun with building random software on Ubuntu with -Werror as they have -Wformat=2 enabled by default and at least last time I tried it was causing some false positives :)

Whatever, this one is correct and committed now... thanks :)

2008-08-31  Sebastian Dröge  <sebastian.droege@collabora.co.uk>

        Patch by: Craig Keogh <cskeogh at adam dot com dot au>

        * ext/annodex/gstcmmlparser.c: (gst_cmml_parser_parse_chunk):
        Fix compiler warnings caused by passing a string as format string
        instead of "%s" and then the string. This is only exposed by -Wformat=2
        as used by default on Ubuntu. Fixes bug #550015.