After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 549799 - all audio codecs claim to support up to 6 channels
all audio codecs claim to support up to 6 channels
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal blocker
: 0.10.5
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-08-29 08:46 UTC by Tim-Philipp Müller
Modified: 2008-08-29 09:54 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Tim-Philipp Müller 2008-08-29 08:46:18 UTC
I think this commit should be reverted at least for the upcoming release:

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ff_aud_caps_new):
	ffmpeg audio decoders can now do up to 6 channels... and actually
	expose it properly. Don't expect any channel mapping though.

IMHO, pad templates should announce possibilities and not impossibilities.

For decoders this is probably less critical, but in the case of encoders this could lead to breakages, e.g. ffenc_mp2 now advertises to support 6 channels. Arguably our ffmpeg encoder caps have a long history of being incomplete and broken, but we should try not to add more such things.

My suggestion is to white-list the decoders that can output 6 channels for now, and use [1, 2] for all other elements for the upcoming release.
Comment 1 Tim-Philipp Müller 2008-08-29 09:19:12 UTC
This should work rather than error out with not-negotiated:

  gst-launch-0.10 audiotestsrc ! audioconvert ! audio/x-raw-int,channels=6 ! audioconvert ! ffenc_mp2 ! fakesink

Comment 2 Edward Hervey 2008-08-29 09:54:29 UTC
2008-08-29  Edward Hervey  <edward.hervey@collabora.co.uk>

	* ext/ffmpeg/gstffmpegcodecmap.c: (gst_ff_aud_caps_new):
	Instead of marking all audio decoders/encoders as accepting up to 6
	channels, we white-list those for which we are sure they can handle
	those 6 channels.
	Fixes #549799