After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 549700 - Drop libglade dependency and use GtkBuilder instead
Drop libglade dependency and use GtkBuilder instead
Status: RESOLVED FIXED
Product: gnome-utils
Classification: Deprecated
Component: screenshot
2.23.x
Other Linux
: Normal enhancement
: ---
Assigned To: Jonathan Blandford
gnome-utils Maintainers
Depends on:
Blocks: 572883
 
 
Reported: 2008-08-28 11:25 UTC by Cosimo Cecchi
Modified: 2008-08-28 16:58 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement


Attachments
[PATCH] Drop glade dependency and use GtkBuilder instead. (28.51 KB, patch)
2008-08-28 11:26 UTC, Cosimo Cecchi
committed Details | Review
[PATCH] Leftover: also edit POTFILES.in (523 bytes, patch)
2008-08-28 11:38 UTC, Cosimo Cecchi
none Details | Review
[PATCH] Fix POTFILES.in with the correct mime type this time. (544 bytes, patch)
2008-08-28 13:16 UTC, Cosimo Cecchi
committed Details | Review

Description Cosimo Cecchi 2008-08-28 11:25:59 UTC
SSIA, patch coming.
Comment 1 Cosimo Cecchi 2008-08-28 11:26:33 UTC
Created attachment 117517 [details] [review]
[PATCH] Drop glade dependency and use GtkBuilder instead.

 configure.ac                            |    3 +-
 gnome-screenshot/Makefile.am            |   10 +-
 gnome-screenshot/gnome-screenshot.c     |    2 -
 gnome-screenshot/gnome-screenshot.glade |  259 -------------------------------
 gnome-screenshot/gnome-screenshot.ui    |  241 ++++++++++++++++++++++++++++
 gnome-screenshot/screenshot-dialog.c    |   27 ++--
 gnome-screenshot/screenshot-dialog.h    |    1 -
 7 files changed, 262 insertions(+), 281 deletions(-)
Comment 2 Emmanuele Bassi (:ebassi) 2008-08-28 11:33:19 UTC
awesome. patch looks good, but the po/POTFILES.in should also be changed to allow the i18n teams to fix up their translations. I don't think this warrants a string freeze break, but I'll ask.
Comment 3 Cosimo Cecchi 2008-08-28 11:38:13 UTC
Created attachment 117518 [details] [review]
[PATCH] Leftover: also edit POTFILES.in

 po/POTFILES.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Comment 4 Cosimo Cecchi 2008-08-28 11:39:04 UTC
Ok, let's wait for i18n then :)
Comment 5 Emmanuele Bassi (:ebassi) 2008-08-28 12:54:24 UTC
for reference, from IRC:

13:52 < uws> ebassi: i think the gtkbuilder move is safe
13:52 < uws> ebassi: you can try "intltool-update it"  in the po/ directory, note the numbers
13:52 < uws> ebassi: then apply the patch, run "intltool-update it" in the po/ directory again, and check the numbers

also, the POTFILES.in should be:

[type: gettext/glade]gnome-screenshot/gnome-screenshot.ui

because intltool does not natively support gtkbuilder files.
Comment 6 Cosimo Cecchi 2008-08-28 13:16:26 UTC
Created attachment 117523 [details] [review]
[PATCH] Fix POTFILES.in with the correct mime type this time.

 po/POTFILES.in |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Comment 7 Cosimo Cecchi 2008-08-28 13:17:53 UTC
with the patch:

anarki@pluto:~/Sources/gnome-utils/po$ intltool-update it
...................................................................................... done.
700 translated messages, 27 fuzzy translations, 11 untranslated messages.

without the patch:

anarki@pluto:~/Sources/gnome-utils/po$ intltool-update it
...................................................................................... done.
701 translated messages, 26 fuzzy translations, 11 untranslated messages.

I saw that new strings are automatically picked up from the .ui file by doing intltool-update. I don't really know how all this stuff works though.
Comment 8 Emmanuele Bassi (:ebassi) 2008-08-28 13:42:29 UTC
a fuzzy string less. might be a fluke, but at least there aren't new untranslated strings.

I'd say: go ahead and commit - we'll deal with the l10n teams in case shit happens.
Comment 9 Cosimo Cecchi 2008-08-28 16:58:17 UTC
Committed to trunk, closing as FIXED.

2008-08-28  Cosimo Cecchi  <cosimoc@gnome.org>

	* Makefile.am:
	* gnome-screenshot.c: (main):
	* gnome-screenshot.glade:
	* gnome-screenshot.ui:
	* screenshot-dialog.c: (screenshot_dialog_new),
	(screenshot_dialog_enable_dnd), (screenshot_dialog_get_toplevel):
	* screenshot-dialog.h:
	Drop libglade dependency. Use GtkBuilder instead (#549700).