GNOME Bugzilla – Bug 549642
add aspect ratio estimates to resolution drop-down menu
Last modified: 2010-11-09 13:03:05 UTC
When trying to find resolutions that will not look distorted on a given display, it is handy to pick one with the same aspect ratio as the currently selected display. Since computers do math faster than me, this patch adds the aspect ratio to the drop-down menus.
Created attachment 117487 [details] [review] add aspect ratio estimate to resolution drop-down menu
(In reply to comment #1) > Created an attachment (id=117487) [edit] > add aspect ratio estimate to resolution drop-down menu > Could you also add translator comment to _("%d x %d (%s)"), width, height, aspect)); thing ?:)
... and not use C++ style comments while we're at it.
Created attachment 117539 [details] [review] add aspect ratio estimate to resolution drop-down menu Sure thing; how does this look? I tried to follow the commenting style shown at http://live.gnome.org/TranslationProject/DevGuidelines/Use%20comments
Can someone please commit this? Is there anything else missing?
(In reply to comment #5) > Can someone please commit this? Is there anything else missing? > String freeze/UI freeze/Feature freeze? :)
I really like the idea of showing aspect ratios. But do we need that "truncate the quotient and switch" method? Can't we just take the width/height fraction, reduce it to the GCD of both values, and just use the result for the aspect ratio?
I don't think so. I think it's important to identify aspect ratios into specific "buckets", since many ratios are close, but not exactly, the expected ratio. Basically, we need to handle a certain level of rounding (and forcing), which I think is best handled with the existing switch methodology.
*** Bug 603237 has been marked as a duplicate of this bug. ***