After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 549460 - Ambiguity of word to be translated: "Never"
Ambiguity of word to be translated: "Never"
Status: RESOLVED FIXED
Product: seahorse
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: 2.22.0
Assigned To: Seahorse Maintainer
Seahorse Maintainer
Depends on:
Blocks:
 
 
Reported: 2008-08-26 16:00 UTC by Mitsuya Shibata
Modified: 2008-08-26 21:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch to use pgettext (930 bytes, patch)
2008-08-26 16:10 UTC, Mitsuya Shibata 		none Details | Review
Uses contexts (1.77 KB, patch)
2008-08-26 16:35 UTC, Adam Schreiber 		committed Details | Review

Description Mitsuya Shibata 2008-08-26 16:00:13 UTC 
In GUI, Seahorse uses "Never" in a different context.

First: "Never" means "Do not trust."
 libseahorse/seahorse-validity.c
 pgp/seahorse-pgp-key-properties.c:1177

Last: "Never" means "Expire is unlimited."
 pgp/seahorse-pgp-key-properties.c:1309
 pgp/seahorse-pgp-key-properties.c:1381

(Line numbers are besed on revision 2307)


In this case, you should use pgettext() [1] instead of gettext(),
or use words which differ from each other.


[1] http://www.gnu.org/software/gettext/manual/gettext.html#Contexts
Comment 1 Mitsuya Shibata 2008-08-26 16:10:12 UTC 
Created attachment 117414 [details] [review]
patch to use pgettext

Attach patch file which adopted the pgettext way.
Comment 2 Mitsuya Shibata 2008-08-26 16:12:39 UTC 
FYI, pgettext() requires gettext 0.15 or later.
Comment 3 Adam Schreiber 2008-08-26 16:35:07 UTC 
Created attachment 117415 [details] [review]
Uses contexts

Using pgettext instead of C_() differs stylistically from the rest of seahorse's code.  Please verify that the attached patch also solves the problem satisfactorily.
Comment 4 Mitsuya Shibata 2008-08-26 18:38:40 UTC 
Hi Schreiber,

Thank you for your advice, and sorry for my ignorance
about seahorse's coding style.
It seems that your patch has no problem.

Regards,
Comment 5 Adam Schreiber 2008-08-26 21:43:12 UTC 
2008-08-26  Adam Schreiber  <sadam@clemson.edu>

    * libseahorse/seahorse-validity.c:
    * pgp/seahorse-pgp-key-properties.c: Clear up ambiguity by adding contexts.
    Fixes bug #549460