After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 549374 - unclear strings
unclear strings
Status: RESOLVED FIXED
Product: anjuta
Classification: Applications
Component: core application
SVN TRUNK
Other Linux
: Normal normal
: ---
Assigned To: James Liggett
Anjuta maintainers
: 552157 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-08-25 23:41 UTC by Christian Kirbach
Modified: 2008-12-14 09:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
partial fix (17.75 KB, patch)
2008-08-26 08:42 UTC, Yuriy Penkin
none Details | Review
partial fix 2 (19.36 KB, patch)
2008-08-26 20:00 UTC, Yuriy Penkin
none Details | Review
update strings (21.33 KB, patch)
2008-08-26 21:02 UTC, Yuriy Penkin
committed Details | Review

Description Christian Kirbach 2008-08-25 23:41:15 UTC
Some unclear strings that need improvements or annotations for translators


all "gtk-*" must not be translatable.

e.g.
../plugins/git/anjuta-git.glade.h:83,84,85



../plugins/git/anjuta-git.glade.h:33
"Add signed off by line"

../plugins/git/anjuta-git.glade.h:35
"Append fetch data"

../plugins/git/anjuta-git.glade.h:36
"Author/Grep"
Comment 1 Yuriy Penkin 2008-08-26 08:42:05 UTC
Created attachment 117388 [details] [review]
partial fix
Comment 2 Yuriy Penkin 2008-08-26 20:00:56 UTC
Created attachment 117420 [details] [review]
partial fix 2

mark some lines for translation
Comment 3 Yuriy Penkin 2008-08-26 21:02:27 UTC
Created attachment 117425 [details] [review]
update strings
Comment 4 Christian Kirbach 2008-08-27 12:09:38 UTC
Comment on attachment 117425 [details] [review]
update strings

The patch removes a lot of "gtk-*" translatable strings which is good. It also adds few new translatable (?).
However this part seems wrong to me

 			g_object_set (G_OBJECT (action),
-					"label", label, 
-              				"tooltip", tooltip, 
+					"label", _(label), 
+              				"tooltip", _(tooltip), 


Also it does not address the problem of previously mentioned unclear strings.
Comment 5 Yuriy Penkin 2008-08-27 18:10:54 UTC
> Also it does not address the problem of previously mentioned unclear strings.

Yes. It's partial fix. I think it's unessential issue for filling a bug. It's only need add annotations for some lines to my patch.
Comment 6 James Liggett 2008-08-30 20:09:01 UTC
(In reply to comment #0)
> ../plugins/git/anjuta-git.glade.h:33
> "Add signed off by line"
A signed off by line is something git adds to the end of a commit message that indicates that a patch passes your scrutiny as you commit it to your git tree. For example, if I apply a patch from someone else and ask git for a signed off by line, it would add "Signed off by James Liggett <jrliggett@cox.net>" to the end of the commit log. It's also possible that the patch could have other signoff lines before I get to it. In effect, these lines are a record of who reviewed a patch. To see this practice in action, you might want to check out Linux's git tree at kernel.org.
> 
> ../plugins/git/anjuta-git.glade.h:35
> "Append fetch data"
Normally when you fetch new objects from a remote branch you're tracking, git overwrites the data from the last fetch. With this option, data will be appended to the previous infofmation, preserving it if the iser should need it.
> 
> ../plugins/git/anjuta-git.glade.h:36
> "Author/Grep"
"Author" means search for commits whose author matches tne given grep expression. "Grep" searches through commit logs and patches.
> 

Comment 7 Johannes Schmid 2008-09-02 07:08:19 UTC
Committed after fixing the breakpoint issue mentioned by Christian.

Is it possible to add context to glade files so we can make the information from comment #6 available for everyone?
Comment 8 Christian Kirbach 2008-09-14 13:42:29 UTC
*** Bug 552157 has been marked as a duplicate of this bug. ***
Comment 9 Christian Kirbach 2008-09-21 10:20:46 UTC
spotted another one

../plugins/tools/tool.c:81
"Same than output"


Found this

Version 2.6.1 (Oct 12 2004) 
* Support "translatable", "context" and "comments" attributes for text properties to help with translation.

but no idea how to mark glade attributes
Comment 10 Sébastien Granjoux 2008-09-21 13:19:54 UTC
(In reply to comment #9)
> spotted another one
> ../plugins/tools/tool.c:81
> "Same than output"

It means that the message send to the error stream (stderr) should be send to the same destination than the output stream.
Comment 11 Naba Kumar 2008-11-30 22:44:57 UTC
(In reply to comment #10)
> (In reply to comment #9)
> > spotted another one
> > ../plugins/tools/tool.c:81
> > "Same than output"
> 
> It means that the message send to the error stream (stderr) should be send to
> the same destination than the output stream.
> 
Should it be better written as 'Same as output' or 'Same as standard output'?
Comment 12 Christian Kirbach 2008-12-01 22:31:53 UTC
"Same as output" is definitely better and proper English.
'than' is used for comparisons only - e.g. 'smaller than foo'
Comment 13 Sébastien Granjoux 2008-12-11 21:47:54 UTC
Sorry for my bad English. I have fixed the "Same as output" message in the tools plugin. Is there some else to do in this bug ?
Comment 14 Christian Kirbach 2008-12-13 23:04:43 UTC
Feel free to add James' comments as translator comments, they are excellent hints.

Regarding the original problem I am closing this report now, thanks.
Comment 15 Sébastien Granjoux 2008-12-14 09:29:41 UTC
Ok, thanks. It's possible to add translator comments in glade files using the the comments attributes. I have added James' comments.