After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 549235 - gtkhtml-spell-language.c translator comments not in the PO file
gtkhtml-spell-language.c translator comments not in the PO file
Status: RESOLVED FIXED
Product: GtkHtml
Classification: Other
Component: Editing
3.23.x
Other All
: Normal normal
: ---
Assigned To: Srinivasa Ragavan
Srinivasa Ragavan
Depends on:
Blocks:
 
 
Reported: 2008-08-24 22:31 UTC by Leonardo Ferreira Fontenelle
Modified: 2008-09-01 13:06 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Translator comments replaced and improved (1.74 KB, patch)
2008-08-24 22:43 UTC, Leonardo Ferreira Fontenelle
reviewed Details | Review
Translator comments and configure.in fix (2.49 KB, patch)
2008-08-31 21:42 UTC, Leonardo Ferreira Fontenelle
none Details | Review
Correct patch (2.85 KB, patch)
2008-08-31 21:49 UTC, Leonardo Ferreira Fontenelle
committed Details | Review

Description Leonardo Ferreira Fontenelle 2008-08-24 22:31:03 UTC
The language context of the components/editor/gtkhtml-spell-language.c has some nice translator comments, but they are not shown in the message catalog:

http://l10n.gnome.org/POT/gtkhtml.HEAD/gtkhtml.HEAD.pot
Comment 1 Leonardo Ferreira Fontenelle 2008-08-24 22:43:19 UTC
Created attachment 117320 [details] [review]
Translator comments replaced and improved
Comment 2 Srinivasa Ragavan 2008-08-31 05:19:38 UTC
Quoting Christian Rose from http://bugzilla.gnome.org/show_bug.cgi?id=249844#c18

gettext now natively supports adding context to strings, with the msgctxt()
call. We will most likely switch to this gettext way of marking context
elsewhere in GNOME (however this is not yet finally decided), but perhaps it
would make sense to use the C_ macro instead of the Q_ macro when patching this
(if requirements allow it). See
http://live.gnome.org/GnomeGoals/MsgctxtMigration

Can you change your patch?
Comment 3 Leonardo Ferreira Fontenelle 2008-08-31 21:42:58 UTC
Created attachment 117726 [details] [review]
Translator comments and configure.in fix

configure.in fix following chpe's comment in http://live.gnome.org/GnomeGoals/MsgctxtMigration. Same translator comments for the meaning of every "%s", but now without the comments on the msgid before the pipe.

Please check if this is correct, I cannot guarantee it will work as expected. (Well, at least gtkhtml still compiles.) If there's any problem with the C_ part, please remember we translators need that comments anyway to understand the possible values to be replaced in each "%s".
Comment 4 Leonardo Ferreira Fontenelle 2008-08-31 21:49:42 UTC
Created attachment 117728 [details] [review]
Correct patch

Actually the last patch ommitted the fix in configure.in (upgraded dependency to intltool 0.36.3). This new patch has it all (C_, %s comments, and configure.in fix).
Comment 5 Srinivasa Ragavan 2008-09-01 03:58:15 UTC
Commit to trunk
Comment 6 Suman Manjunath 2008-09-01 04:13:27 UTC
Patch committed to SVN trunk as r8943
http://svn.gnome.org/viewvc/gtkhtml?view=revision&revision=8943
Comment 7 Leonardo Ferreira Fontenelle 2008-09-01 13:06:18 UTC
Funny, I thoght I had already closed this bug report.