After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 549183 - Delete playlist action on DAPs using eject icon
Delete playlist action on DAPs using eject icon
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: User Interface
git master
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
Depends on:
Blocks:
 
 
Reported: 2008-08-24 09:32 UTC by Michael Monreal
Modified: 2008-09-08 01:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot (13.21 KB, image/png)
2008-08-24 09:33 UTC, Michael Monreal 		  Details
Use the proper icon for deleting DAP playlists (684 bytes, patch)
2008-08-24 12:13 UTC, Bertrand Lorentz 		none Details | Review

Description Michael Monreal 2008-08-24 09:32:47 UTC 
On DAP sources, the "Delete playlist" action uses the eject icon instead of the delete one.
Comment 1 Michael Monreal 2008-08-24 09:33:12 UTC 
Created attachment 117293 [details]
Screenshot
Comment 2 Bertrand Lorentz 2008-08-24 12:10:28 UTC 
The playlist inherits the property setting the icon from its parent source.

I'll attach a patch.
Comment 3 Bertrand Lorentz 2008-08-24 12:13:48 UTC 
Created attachment 117294 [details] [review]
Use the proper icon for deleting DAP playlists

This patch overrides the UnmapSourceActionIconName for DAP playlists.
Comment 4 Gabriel Burt 2008-09-08 01:13:31 UTC 
I ended up fixing this in a different way - by not having children inherit the label/icon overrides of their parents, but adding a property to PrimarySources for the 'StorageName' (eg Drive or iPod) to be used in the DeleteFromDriveAction label.  Fixed in svn.