Bug 548738 – Segfault trying to see properties of an image with XMP metadata

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 548738 - Segfault trying to see properties of an image with XMP metadata


Summary:	Segfault trying to see properties of an image with XMP metadata


Status:	RESOLVED FIXED

Product:	eog
Classification:	Core
Component:	image viewer
Version:	2.23.x
Hardware:	Other Linux

Importance:	High critical
Target Milestone:	---
Assigned To:	EOG Maintainers
QA Contact:	EOG Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2008-08-20 20:05 UTC by Mikel Olasagasti
Modified:	2008-08-22 10:09 UTC

See Also:
GNOME target:	---
GNOME version:	---

Description Mikel Olasagasti 2008-08-20 20:05:05 UTC

I get a segfault if I try to see the properties of an image that has XMP metadata.

I'm using eog-2.23.90 with exempi-2.0.2

Image:

http://gitweb.freedesktop.org/?p=exempi.git;a=blob;h=91589cd53aeaeb92fbddab46940637fb6ec50b41;hb=8ddcec9ed725de51d97dccca345e02863746b084;f=samples/BlueSquares/BlueSquare.png

gdb log:

(gdb) bt

+ Trace 205455

#0 eog_properties_dialog_update
#1 image_thumb_changed_cb
#2 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#3 ??
from /usr/lib/libgobject-2.0.so.0
#4 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#5 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#6 eog_job_thumbnail_cb
#7 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#8 ??
from /usr/lib/libgobject-2.0.so.0
#9 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#10 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#11 notify_finished
#12 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#13 ??
from /usr/lib/libglib-2.0.so.0
#14 g_main_loop_run
from /usr/lib/libglib-2.0.so.0
#15 gtk_main
from /usr/lib/libgtk-x11-2.0.so.0
#16 main

Comment 1 Claudio Saavedra 2008-08-20 20:11:32 UTC

Thanks for taking the time to report this bug.
Unfortunately, that stack trace is missing some elements that will help a lot to solve the problem, so it will be hard for the developers to fix that crash. Can you get us a stack trace with debugging symbols? Please see http://live.gnome.org/GettingTraces for more information on how to do so and reopen this bug or report a new one. Thanks in advance!

Comment 2 Mikel Olasagasti 2008-08-20 20:21:49 UTC

Now with 62% more of symbols!

Program received signal SIGSEGV, Segmentation fault.

+ Trace 205456

Thread 140332934559632 (LWP 10273)

#0 eog_exif_set_focal_length_label
at eog-properties-dialog.c line 206
#1 pd_update_metadata_tab
at eog-properties-dialog.c line 364
#2 eog_properties_dialog_update
at eog-properties-dialog.c line 725
#3 eog_window_cmd_properties
at eog-window.c line 2801
#4 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#5 ??
from /usr/lib/libgobject-2.0.so.0
#6 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#7 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#8 ??
from /usr/lib/libgtk-x11-2.0.so.0
#9 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#10 ??
from /usr/lib/libgobject-2.0.so.0
#11 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#12 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#13 gtk_widget_activate
from /usr/lib/libgtk-x11-2.0.so.0
#14 gtk_menu_shell_activate_item
from /usr/lib/libgtk-x11-2.0.so.0
#15 ??
from /usr/lib/libgtk-x11-2.0.so.0
#16 ??
from /usr/lib/libgtk-x11-2.0.so.0
#17 g_closure_invoke
from /usr/lib/libgobject-2.0.so.0
#18 ??
from /usr/lib/libgobject-2.0.so.0
#19 g_signal_emit_valist
from /usr/lib/libgobject-2.0.so.0
#20 g_signal_emit
from /usr/lib/libgobject-2.0.so.0
#21 ??
from /usr/lib/libgtk-x11-2.0.so.0
#22 gtk_propagate_event
from /usr/lib/libgtk-x11-2.0.so.0
#23 gtk_main_do_event
from /usr/lib/libgtk-x11-2.0.so.0
#24 ??
from /usr/lib/libgdk-x11-2.0.so.0
#25 g_main_context_dispatch
from /usr/lib/libglib-2.0.so.0
#26 ??
from /usr/lib/libglib-2.0.so.0
#27 g_main_loop_run
from /usr/lib/libglib-2.0.so.0
#28 gtk_main
from /usr/lib/libgtk-x11-2.0.so.0
#29 main
at main.c line 229

Comment 3 Felix Riemann 2008-08-21 10:16:32 UTC

Thanks. My fault once again.
While splitting off the focal length label from the others I forgot that exif_data could be NULL (when the image only has XMP).

2008-08-21  Felix Riemann  <>

	* src/eog-properties-dialog.c: (eog_exif_set_focal_length_label):
	Fix segfaults with XMP-only files when opening properties dialog.
	Fixes bug #548738.

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.

Comment 4 Claudio Saavedra 2008-08-21 10:24:42 UTC

Felix, small nitpicking:

> +        * cleared later as *fl35text is NULL. */

You actually mean fl35text, no need for the * there :-)

Comment 5 Felix Riemann 2008-08-22 10:09:41 UTC

(In reply to comment #4)
> 
> You actually mean fl35text, no need for the * there :-)
> 

No, actually I meant fl35_text. ;-)
Wonder how that could happen.