After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548701 - improve chat window title with multi tabs
improve chat window title with multi tabs
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
2.23.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
: 586015 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-08-20 16:56 UTC by Pedro Villavicencio
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/tab-title-548701 (5.84 KB, patch)
2009-11-25 17:27 UTC, Guillaume Desmottes
reviewed Details | Review

Description Pedro Villavicencio 2008-08-20 16:56:47 UTC
this bug has been filed here:

https://bugs.edge.launchpad.net/ubuntu/+source/empathy/+bug/259469

"With multiple conversations (eg 2) in one conversation window, the title in the titlebar is Conversations (2).
All other applications i have seen with tabs show the current tab title as the window title (ie in this case, the contact name)
Emapthy should be made to be consistent"

Thanks,
Comment 1 Xavier Claessens 2008-08-20 17:47:31 UTC
Hm, i'm not sure about that, having "Conversations (2)" has the advantage of telling the user that window has more than one chat, if it displays the active one the user could not know where other chats are...

But I agree that making consistent with other app is a good argument, and having "Conversation (2)" doesn't tell much about which conversations it is...
Comment 2 Will Thompson 2008-08-20 17:50:56 UTC
A downside of showing the name of the currently-selected tab as the title is that you get your taskbar flashing with a new message from Xavier when actually it was Pedro who sent you a message in another tab.
Comment 3 Xavier Claessens 2008-08-20 17:55:03 UTC
Will, I think it should switch to the chat that received a message when setting urgency hint on the window... Or is it already done?
Comment 4 Frederic Peters 2008-08-20 18:57:58 UTC
I agree window title should change according to selected tab; the behaviour on new message when the window is in the window list should be tested (I don't have a window list).
Comment 5 Will Thompson 2008-08-20 21:07:09 UTC
Pidgin tried changing the active tab when a new message came in, and it's a disaster – you alt-tab away from your IM window, alt-tab back, paste some stuff and lo! it's gone to the wrong person.

Changing just the title might work, but might be confusing.  Would the title change back when you focus the window?
Comment 6 Pierre-Luc Beaudoin 2009-06-19 01:39:18 UTC
*** Bug 586015 has been marked as a duplicate of this bug. ***
Comment 7 Guillaume Desmottes 2009-11-23 14:34:31 UTC
Empathy master now uses the title of the current tab as Window title. But as Will mentioned this is not optimal and we can certainly improve that.

What do you think about this (assuming 'Alice' is the focussed tab):

- one tab open: "Alice"
- n+1 tabs open: "Alice (and n others)"
- one tab open, m unread messages: "Alice (m unread)"
- n+1 tabs open, m unread messages from Alice: "Alice (m unread)"
- n+1 tabs open, m unread messages from the other contacts: "Alice (m unread from others)"

I'm not sure if we should include the information about the number of other tabs when we have unread message. Imho the number of unread msgs is a more valuable information and displaying both will be too long.

Thoughts?
Comment 8 Nick Richards 2009-11-23 18:54:10 UTC
How important is the number of unread messages vs the number of unread conversations? The assumption that each message is of the same value or posting style is quite brittle (5 four word messages vs 1 200 word message) although there's possibly some value in it, albeit time dependent (5 unread messages over 10 minutes is different to 5 unread messages over 5 hours). I would agree that 'unreadness' is more important than total conversations though.

Aside from that, it all seems pretty sane. How about this scenario though:

- n+1 tabs open, m unread messages from alice and m2 from other contacts: "Alice (m+m2 unread from everyone)
Comment 9 Guillaume Desmottes 2009-11-25 17:27:28 UTC
Created attachment 148454 [details] [review]
http://git.collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/tab-title-548701

 libempathy-gtk/empathy-chat.c |   23 ++++++++++
 libempathy-gtk/empathy-chat.h |    3 +
 src/empathy-chat-window.c     |   96 +++++++++++++++++++++++++++++++++++++++-
 3 files changed, 119 insertions(+), 3 deletions(-)
Comment 10 Will Thompson 2009-11-25 17:38:34 UTC
                      ____________________________
                     /                            \
                    /______________________________\
                    | Bikes (2 unused from others) |
                    |------------------------------|
                    |  ___                         |
    ,_~o      ,_~o  | |   |                        |
  _-\_<,    _-\_<,  | |•  |                        |
 (*)/'(*)  (*)/'(*) |_|___|________________________|

I don't like the word "everyone" in:

  %s (%d unread from everyone)

but I can't think of a better word to use to mean "%s and the other people, combined" off-hand.
Comment 11 Cosimo Cecchi 2009-11-25 20:31:08 UTC
Review of attachment 148454 [details] [review]:

I don't like "everyone" too much there as well, but can't think of another term.
I also added some nit-picky comments below :)

::: src/empathy-chat-window.c
@@ +419,3 @@
+
+		else if (current_unread_msgs == 0) {
+			/* unread messages are in others tab */

s/others tab/other tabs/

@@ +1197,3 @@
 	if (has_focus && priv->current_chat == chat) {
+		/* window and tab are focused so consider than the message is
+		 * read */

s/than the message is read/the message as read/ should be more correct
Comment 12 Guillaume Desmottes 2009-11-26 10:42:02 UTC
Thanks Cosimo, I fixed those.

Any suggestion for a better name than "everyone"? Nick?
I don't really want to block this branch if we don't know how to improve it. :)
Comment 13 Nick Richards 2009-11-26 12:52:11 UTC
Awesome ASCII art Will, that's made my day. I can't really think of a better one word phrase that keeps the same form 'from X' without sounding hilariously stilted 'from ongoing conversations'. You could try 'from all'?

/irrelevant digression I took a quick look in a thesaurus to try and think of something new which offered the option 'from all and sundry' which is smashing. Very Moblin tone of voice, not very gnome.
Comment 14 Guillaume Desmottes 2009-11-27 15:31:39 UTC
Merged to master with "everyone" changed to "all".

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.