GNOME Bugzilla – Bug 548635
Banshee opens videos in a new window; closing this window crashes Banshee
Last modified: 2010-05-02 03:55:17 UTC
Steps to reproduce: 1. Start Banshee 2. Double click "Favorites" video library 3. Watch Banshee starting the video in a new window. Try to close one of the windows and Banshee crashes Stack trace: [Info 13:48:58.574] Running Banshee 1.2.1 [Info 13:49:00.508] All services are started 1,7329s [Info 13:49:01.392] nereid Client Started [Warn 13:49:02.407] Caught an exception - Text node cannot appear in this state. Line 1, position 1. (in `System.Xml') at Mono.Xml2.XmlTextReader.ReadText (Boolean notWhitespace) [0x00000] at Mono.Xml2.XmlTextReader.ReadContent () [0x00000] at Mono.Xml2.XmlTextReader.Read () [0x00000] at System.Xml.XmlTextReader.Read () [0x00000] at System.Xml.XmlDocument.ReadNodeCore (System.Xml.XmlReader reader) [0x00000] at System.Xml.XmlDocument.ReadNode (System.Xml.XmlReader reader) [0x00000] at System.Xml.XmlDocument.Load (System.Xml.XmlReader xmlReader) [0x00000] at System.Xml.XmlDocument.LoadXml (System.String xml) [0x00000] at Migo.Syndication.RssParser..ctor (System.String url, System.String xml) [0x00000] [Warn 13:49:02.408] Caught an exception - Invalid XML document. (in `Migo') at Migo.Syndication.RssParser..ctor (System.String url, System.String xml) [0x00000] at Migo.Syndication.FeedUpdateTask.OnDownloadDataReceived (System.Object sender, Migo.Net.DownloadStringCompletedEventArgs args) [0x00000] (Nereid:17616): Gdk-WARNING **: /build/buildd/gtk+2.0-2.12.9/gdk/x11/gdkdrawable-x11.c:878 drawable is not a pixmap or window Nereid: Fatal IO error 11 (Hulpbron is tijdelijk onbeschikbaar) on X server :0.0. Other information:
Found out double clicking Video Library itself is enough to trigger this bug.
I can reproduce this, and I get the same warning : (Nereid.exe:29349): Gdk-WARNING **: gdkdrawable-x11.c:878 drawable is not a pixmap or window It only happens if you never selected the "Now Playing" source before double-clicking on the Video Library.
*** Bug 586895 has been marked as a duplicate of this bug. ***
Another way to reproduce this for me : 1. start banshee 2. File > Open Location and select a video It starts playing in a new window.
I think I also ran into this by adding a video to the Play Queue. When the queue got to the video, it opened in a new window. Closing the new window closed all of Banshee surprisingly fast - a crash would explain that.
*** Bug 602605 has been marked as a duplicate of this bug. ***
Bug 602605 was basically a duplicate of Comment 5 of this bug, which I assume is the same issue as the original bug report. I'm going to update the description to focus on the problem rather than the method of reproducing the problem.
*** Bug 601456 has been marked as a duplicate of this bug. ***
From Bug 601456, playing video from the Internet Archive source seems to be another way to produce this bug.
Created attachment 156776 [details] [review] Patch that works for me This patch is against 1.5.1, so it may not apply to master. It would be helpful to have others build 1.5.1 and test this patch though. If it works, I will port it to master if needed. We have a shipping product with 1.5.1, so that's what I was working against. In my testing, this fixes the issue: 1. Start new Banshee 2. Double click the "videos" source 3. Observe that the video is properly embedded in the "Now Playing" source Thanks
I reported the result of my tests on IRC (with the patch applied to 1.5.1), but forgot to write it here : By following the steps described above, it often works properly, but the video still sometimes opens in a new window.
Same error is happening to me on Banshee 1.6 I was hoping to replace Miro with Banshee, and use one player for all my media, but until this is fixed I'm going to need to keep using Miro.
This is now fixed in the stable-1.6 branch and will be a part of the 1.6.1 release. As I am in the middle of a bug-fixing sprint against 1.6, I have not yet merged all my fixes from the last week to the master branch, thus, this is not merged to master yet. It'll be merged in master sometime next week along with a slew of other fixes. If you wish to test the fix, use the stable-1.6 branch for now. http://git.gnome.org/browse/banshee/commit/?h=stable-1.6&id=9330060c208271bc0213bc13c94adae3ba275c4a