After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548627 - border under group names
border under group names
Status: RESOLVED OBSOLETE
Product: empathy
Classification: Core
Component: Contact List
2.27.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
: 592445 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2008-08-20 11:29 UTC by Frederic Peters
Modified: 2012-06-28 09:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
remove separators from contact list (9.67 KB, patch)
2008-08-20 11:30 UTC, Frederic Peters
rejected Details | Review

Description Frederic Peters 2008-08-20 11:29:08 UTC
Quoting from Matthew review <https://wiki.ubuntu.com/EmpathyVsPidginUsability>:

> There was a border under the heading for each group, which was slightly
> misleading.

I agree with the sentiment; the border doesn't serve much purpose as the group names are already visually distinct.
Comment 1 Frederic Peters 2008-08-20 11:30:09 UTC
Created attachment 117040 [details] [review]
remove separators from contact list

 empathy-contact-list-store.c |   81 ++-----------------------------------------
 empathy-contact-list-store.h |    4 --
 empathy-contact-list-view.c  |    4 --
 3 files changed, 5 insertions(+), 84 deletions(-)

You can't argue with a patch removing so much stuff :)
Comment 2 Matthew Paul Thomas (mpt) 2008-08-23 00:31:48 UTC
My problem with the bottom border (which I didn't describe fully in the wiki page) was that, in the absence of any other styling, it makes the group heading look more closely related to the contacts above it than to the contacts that are actually in the group.

Possible solutions include adding extra whitespace above group names (though it might be tricky to make that look good and compact), and/or using a background tint or gradient instead of a border.

(Fun fact: Pidgin has exactly the same issue, and Sean Egan told me that Pidgin copied the bottom border from Empathy in the first place.)
Comment 3 Xavier Claessens 2008-08-23 09:46:33 UTC
The idea comes from Gossip, I find it pretty nice...
Comment 4 Frederic Peters 2008-08-24 14:56:15 UTC
I find the headers to be enough visually distinct as they have an expander and are not filled with presence status icons.  Also I believe it is the theme role, not an application role, to decide how it should look, if headers should have a bottom border for example.

And it is just not logical to use a *separator* to *join* things together (doesn't it sound like API-abuse?).
Comment 5 Xavier Claessens 2008-08-27 12:37:09 UTC
I would like to know if the GTK theme system is able to set itself and different style to the expander. If it's possible I think I'll mark the patch as commit-after-freeze.
Comment 6 Frederic Peters 2008-08-27 12:38:55 UTC
I talked with Benjamin Berg and he says it is currently not possible.
Comment 7 Xavier Claessens 2008-10-17 15:22:26 UTC
Hm, I'm a bit unsure so... We need a way to visually see groups. When gossip introduced that separator all users where pleased because it's good looking.

I'm rejecting this patch but I let the bug open. We need a way to let the theme engine do something beautiful :)
Comment 8 Guillaume Desmottes 2009-06-10 13:23:43 UTC
Confirming the bug as I think we all agree that this could be improved.
Comment 9 Sumana Harihareswara 2009-10-28 22:02:58 UTC
*** Bug 592445 has been marked as a duplicate of this bug. ***
Comment 10 Sumana Harihareswara 2009-10-28 22:05:41 UTC
https://bugzilla.gnome.org/attachment.cgi?id=141233 from bug# 592445 has a
suggested mockup with extra spacing at the bottom of *expanded* groups within
the contact list (but not contracted groups).
Comment 11 Jean-François Fortin Tam 2012-06-24 15:07:50 UTC
This bug has not had any significant activity in years. I would lean towards closing it, but instead I'll NEEDINFO it with an ultimatum question to be answered:

"What would be considered visually better [than in the current release]?"

If nobody can answer that question within six weeks or so, then it will probably never happen so we might just as well close it :)
Comment 12 Allan Day 2012-06-27 19:13:12 UTC
There's a visual treatment for groups in this mockup:

https://dl.dropbox.com/u/5031519/empathy/buddy-list-new.png

That said, I'm not a big fan of the expanders and would prefer a different approach (bug 670125).
Comment 13 Guillaume Desmottes 2012-06-28 09:22:57 UTC
Let's close this bug as the border is gone with the new roster. I opened bug #679030 about implementing Allan's nice design idea.