After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 548559 - spi_atk_tidy_windows prints a critical if atk_get_root() returns NULL
spi_atk_tidy_windows prints a critical if atk_get_root() returns NULL
Status: RESOLVED FIXED
Product: at-spi
Classification: Platform
Component: atkbridge
1.23.x
Other All
: Normal trivial
: ---
Assigned To: Li Yuan
Li Yuan
Depends on:
Blocks:
 
 
Reported: 2008-08-20 01:56 UTC by Mike Gorse
Modified: 2008-08-29 02:03 UTC
See Also:
GNOME target: ---
GNOME version: 2.23/2.24


Attachments
Simple patch (367 bytes, patch)
2008-08-20 01:58 UTC, Mike Gorse
committed Details | Review

Description Mike Gorse 2008-08-20 01:56:26 UTC
Please describe the problem:
spi_atk_tidy_windows calls atk_get_root(), then retrieves the number of children on the returned object.  We will likely modify the UIA-to-ATK bridge to remove its get_root handler before _exit is called, since the Mono runtime is gone by then and we would otherwise get a crash.  A critical gets displayed in this situation because atk-bridge calls atk_object_get_n_accessible_children on a null object.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Mike Gorse 2008-08-20 01:58:01 UTC
Created attachment 117021 [details] [review]
Simple patch
Comment 2 Li Yuan 2008-08-20 02:09:40 UTC
Do you mean the GUI objects are destroyed before spi_atk_tidy_windows is called?
Comment 3 Mike Gorse 2008-08-20 02:24:30 UTC
Yes, the objects are gone along with the infrastructure to return a root object.
Comment 4 Li Yuan 2008-08-20 03:04:45 UTC
Do you have commit permission?
Comment 5 Mike Gorse 2008-08-20 03:30:34 UTC
No, I don't have commit permission.
Comment 6 Andrés G. Aragoneses (IRC: knocte) 2008-08-28 20:21:52 UTC
Li, thanks for committing.

However, please note, you confused the number of the bug in the changelog:

http://svn.gnome.org/viewvc/at-spi?view=revision&revision=1046

Can you fix the changelog? Thanks.
Comment 7 Li Yuan 2008-08-29 02:03:36 UTC
Oops, thanks for reminding me. Have updated the changelog.